Re: [O] org-map-entries calls org-agenda-prepare-buffers unnecessarily?

[Nicolas Goaziou]

Hello,

Adam Porter <address@hidden> writes:

> I've noticed that org-map-entries calls org-agenda-prepare-buffers
> whenever its SCOPE argument is nil.  According to the docstring, a nil
> SCOPE means, "The current buffer, respecting the restriction if any," so
> it doesn't seem necessary to call org-agenda-prepare-buffers.

Here be dragons!

> I noticed this because I have a function in my org-mode-hook that runs
> org-map-entries (applying a read-only property to entries with a
> read_only tag), and whenever I find-file on a non-existent Org file, I'm
> prompted, "Non-existent agenda file %s.  [R]emove from list or
> [A]bort?", which is caused by org-map-entries being called with a nil
> SCOPE, which calls org-agenda-prepare-buffers, which calls
> org-check-agenda-file on the not-yet-existent file.  So if this behavior
> is indeed unnecessary, it would be nice to fix it.

For simple cases like yours, I suggest to map over headlines manually,
e.g., 

  (goto-char (point-min))
  (unless (org-at-heading-p) (outline-next-heading))
  (while (not (eobp))
   ... do stuff...)

> Is this a bug, or am I missing something?

Neither. `org-map-entries' is a complex function that arguably does more
than it should.

Regards,

-- 
Nicolas Goaziou