Re: [O] [PATCH] migrate ob-clojure initiate session code from ob-clojure-literate.el into ob-clojure.el

[Nicolas Goaziou]

Hello,

stardiviner <address@hidden> writes:

> Nicolas Goaziou <address@hidden> writes:
>
> Hi, sorry for late response, because I'm a little lazy on give effort on
> review my patch and improve it again. But now I finished it. Actually I
> corrected my patch as soon as you replied email with mentioned. Today I
> pick up this task again, and add a new improve which support CIDER new
> API which using sesman to manage REPL sessions.

OK. So does it qualify as a bug fix, i.e., should that go into master
branch, or is it a new feature, for next branch?

BTW, there are some compilation warning:

--8<---------------cut here---------------start------------->8---
Compiling /home/ngz/dev/org-mode/lisp/ob-clojure.el...

In toplevel form:
ob-clojure.el:215:1:Warning: Unused lexical variable ‘sesman-system’

In org-babel-clojure-initiate-session:
ob-clojure.el:225:47:Warning: reference to free variable ‘cider-version’

In end of data:
ob-clojure.el:278:1:Warning: the function ‘cider-repls’ is not known to be
    defined.
--8<---------------cut here---------------end--------------->8---

Could you fix them?

Thank you.

Regards,

-- 
Nicolas Goaziou