Re: [O] [Proposal] Make header argument :mkdirp yes work for other header arguments not just :tangle

[stardiviner]

Christopher M. Miles <address@hidden> writes:

> I hope `:mkdirp` header argument can also work for other related header
> arguments like `:dir`, `:file` etc not just `:tangle`. Like following
> example.
>
> #+begin_src sh :mkdirp yes :dir "data/code/mkdirp/dir" :file "test" :results 
> file link
> echo "hello"
> #+end_src
>
> Do you have any idea about this?

I made a patch for make ~:mkdir~ support for ~:dir~ header argument. But I 
still got
some issues. I added patch in attachment.

0001-ob-core.el-Make-mkdirp-work-for-dir-too.patch
Description: Text Data

I can't run through many org babel related tests. When I revert my patch in
source code, and run test again, the failed tests all passed. So the problem is
in my code, but I don't understand where's wrong. The ~let~ form suppose to 
return
~default-directory~ correctly.

Even I run the single test with "test-dirty", It seems don't report fail or
success status in output:

Here is the command I run and the command output:

#+begin_src sh :dir "~/Code/Emacs/org-mode" :async
make BTEST_RE="test-org-core/dir-mkdirp" test-dirty 2>&1 | cat
#+end_src

#+RESULTS[<2019-03-02 12:24:25> 3e762f60ab3c3ec0550a29b8dbf8717707dec0e5]:
#+begin_example
install -m 755 -d /tmp/tmp-orgtest
TMPDIR=/tmp/tmp-orgtest emacs  -Q -batch --eval '(setq vc-handled-backends nil 
org-startup-folded nil)'  --eval '(add-to-list '"'"'load-path (concat 
default-directory "lisp"))' --eval '(add-to-list '"'"'load-path (concat 
default-directory "testing"))'  -l org-batch-test-init --eval '(setq 
org-batch-test t org-babel-load-languages (quote ( (awk . t)  (C . t)  (fortran 
. t)  (maxima . t)  (lilypond . t)  (octave . t)  (perl . t)  (python . t)  
(vala . t)  (emacs-lisp . t)  (shell . t)  (org . t))) org-test-select-re 
"test-org-core/dir-mkdirp" )' -l org-loaddefs.el -l cl -l testing/org-test.el 
-l ert -l org -l ox  --eval '(org-test-run-batch-tests org-test-select-re)'
Finding ID locations (1/25 files): 
/home/stardiviner/Code/Emacs/org-mode/testing/examples/agenda-file.org
Finding ID locations (2/25 files): 
/home/stardiviner/Code/Emacs/org-mode/testing/examples/babel-dangerous.org
Finding ID locations (3/25 files): 
/home/stardiviner/Code/Emacs/org-mode/testing/examples/babel.org
Finding ID locations (4/25 files): 
/home/stardiviner/Code/Emacs/org-mode/testing/examples/include.org
Finding ID locations (5/25 files): 
/home/stardiviner/Code/Emacs/org-mode/testing/examples/include2.org
Finding ID locations (6/25 files): 
/home/stardiviner/Code/Emacs/org-mode/testing/examples/link-in-heading.org
Finding ID locations (7/25 files): 
/home/stardiviner/Code/Emacs/org-mode/testing/examples/links.org
Finding ID locations (8/25 files): 
/home/stardiviner/Code/Emacs/org-mode/testing/examples/macro-templates.org
Finding ID locations (9/25 files): 
/home/stardiviner/Code/Emacs/org-mode/testing/examples/no-heading.org
Finding ID locations (10/25 files): 
/home/stardiviner/Code/Emacs/org-mode/testing/examples/normal.org
Finding ID locations (11/25 files): 
/home/stardiviner/Code/Emacs/org-mode/testing/examples/ob-C-test.org
Finding ID locations (12/25 files): 
/home/stardiviner/Code/Emacs/org-mode/testing/examples/ob-awk-test.org
Finding ID locations (13/25 files): 
/home/stardiviner/Code/Emacs/org-mode/testing/examples/ob-fortran-test.org
Finding ID locations (14/25 files): 
/home/stardiviner/Code/Emacs/org-mode/testing/examples/ob-header-arg-defaults.org
Finding ID locations (15/25 files): 
/home/stardiviner/Code/Emacs/org-mode/testing/examples/ob-lilypond-broken.org
Finding ID locations (16/25 files): 
/home/stardiviner/Code/Emacs/org-mode/testing/examples/ob-lilypond-test.org
Finding ID locations (17/25 files): 
/home/stardiviner/Code/Emacs/org-mode/testing/examples/ob-maxima-test.org
Finding ID locations (18/25 files): 
/home/stardiviner/Code/Emacs/org-mode/testing/examples/ob-octave-test.org
Finding ID locations (19/25 files): 
/home/stardiviner/Code/Emacs/org-mode/testing/examples/ob-screen-test.org
Finding ID locations (20/25 files): 
/home/stardiviner/Code/Emacs/org-mode/testing/examples/ob-sed-test.org
Finding ID locations (21/25 files): 
/home/stardiviner/Code/Emacs/org-mode/testing/examples/ob-shell-test.org
Finding ID locations (22/25 files): 
/home/stardiviner/Code/Emacs/org-mode/testing/examples/org-exp.org
Finding ID locations (23/25 files): 
/home/stardiviner/Code/Emacs/org-mode/testing/examples/property-inheritance.org
Finding ID locations (24/25 files): 
/home/stardiviner/Code/Emacs/org-mode/testing/examples/setupfile.org
Finding ID locations (25/25 files): 
/home/stardiviner/Code/Emacs/org-mode/testing/examples/setupfile3.org
25 unique files scanned for IDs
Loading /home/stardiviner/Code/Emacs/org-mode/testing/lisp/test-ob-C.el 
(source)...
Loading /home/stardiviner/Code/Emacs/org-mode/testing/lisp/test-ob-R.el 
(source)...
Loading /home/stardiviner/Code/Emacs/org-mode/testing/lisp/test-ob-awk.el 
(source)...
Loading /home/stardiviner/Code/Emacs/org-mode/testing/lisp/test-ob-clojure.el 
(source)...
Loading /home/stardiviner/Code/Emacs/org-mode/testing/lisp/test-ob-core.el 
(source)...
Loading 
/home/stardiviner/Code/Emacs/org-mode/testing/lisp/test-ob-emacs-lisp.el 
(source)...
Loading /home/stardiviner/Code/Emacs/org-mode/testing/lisp/test-ob-eshell.el 
(source)...
Loading /home/stardiviner/Code/Emacs/org-mode/testing/lisp/test-ob-exp.el 
(source)...
Loading /home/stardiviner/Code/Emacs/org-mode/testing/lisp/test-ob-fortran.el 
(source)...
Loading 
/home/stardiviner/Code/Emacs/org-mode/testing/lisp/test-ob-header-arg-defaults.el
 (source)...
Loading /home/stardiviner/Code/Emacs/org-mode/testing/lisp/test-ob-lilypond.el 
(source)...
Loading /home/stardiviner/Code/Emacs/org-mode/testing/lisp/test-ob-lob.el 
(source)...
0 source block added to Library of Babel
Loading /home/stardiviner/Code/Emacs/org-mode/testing/lisp/test-ob-lua.el 
(source)...
Loading /home/stardiviner/Code/Emacs/org-mode/testing/lisp/test-ob-maxima.el 
(source)...
Loading /home/stardiviner/Code/Emacs/org-mode/testing/lisp/test-ob-octave.el 
(source)...
Loading /home/stardiviner/Code/Emacs/org-mode/testing/lisp/test-ob-perl.el 
(source)...
Loading /home/stardiviner/Code/Emacs/org-mode/testing/lisp/test-ob-plantuml.el 
(source)...
Loading /home/stardiviner/Code/Emacs/org-mode/testing/lisp/test-ob-python.el 
(source)...
Loading /home/stardiviner/Code/Emacs/org-mode/testing/lisp/test-ob-ruby.el 
(source)...
Loading /home/stardiviner/Code/Emacs/org-mode/testing/lisp/test-ob-scheme.el 
(source)...
Loading /home/stardiviner/Code/Emacs/org-mode/testing/lisp/test-ob-sed.el 
(source)...
Loading /home/stardiviner/Code/Emacs/org-mode/testing/lisp/test-ob-shell.el 
(source)...
Loading /home/stardiviner/Code/Emacs/org-mode/testing/lisp/test-ob-sqlite.el 
(source)...
Loading /home/stardiviner/Code/Emacs/org-mode/testing/lisp/test-ob-table.el 
(source)...
Loading /home/stardiviner/Code/Emacs/org-mode/testing/lisp/test-ob-tangle.el 
(source)...
Loading /home/stardiviner/Code/Emacs/org-mode/testing/lisp/test-ob-vala.el 
(source)...
Loading /home/stardiviner/Code/Emacs/org-mode/testing/lisp/test-ob.el 
(source)...
Loading /home/stardiviner/Code/Emacs/org-mode/testing/lisp/test-org-agenda.el 
(source)...
Loading /home/stardiviner/Code/Emacs/org-mode/testing/lisp/test-org-archive.el 
(source)...
Loading 
/home/stardiviner/Code/Emacs/org-mode/testing/lisp/test-org-attach-annex.el 
(source)...
Loading /home/stardiviner/Code/Emacs/org-mode/testing/lisp/test-org-attach.el 
(source)...
Loading /home/stardiviner/Code/Emacs/org-mode/testing/lisp/test-org-bbdb.el 
(source)...
Loading /home/stardiviner/Code/Emacs/org-mode/testing/lisp/test-org-capture.el 
(source)...
Loading /home/stardiviner/Code/Emacs/org-mode/testing/lisp/test-org-clock.el 
(source)...
Loading /home/stardiviner/Code/Emacs/org-mode/testing/lisp/test-org-colview.el 
(source)...
Loading /home/stardiviner/Code/Emacs/org-mode/testing/lisp/test-org-datetree.el 
(source)...
Loading /home/stardiviner/Code/Emacs/org-mode/testing/lisp/test-org-duration.el 
(source)...
Loading /home/stardiviner/Code/Emacs/org-mode/testing/lisp/test-org-element.el 
(source)...
Loading /home/stardiviner/Code/Emacs/org-mode/testing/lisp/test-org-feed.el 
(source)...
Loading /home/stardiviner/Code/Emacs/org-mode/testing/lisp/test-org-footnote.el 
(source)...
Loading /home/stardiviner/Code/Emacs/org-mode/testing/lisp/test-org-info.el 
(source)...
Loading 
/home/stardiviner/Code/Emacs/org-mode/testing/lisp/test-org-inlinetask.el 
(source)...
Loading /home/stardiviner/Code/Emacs/org-mode/testing/lisp/test-org-lint.el 
(source)...
Loading /home/stardiviner/Code/Emacs/org-mode/testing/lisp/test-org-list.el 
(source)...
Loading /home/stardiviner/Code/Emacs/org-mode/testing/lisp/test-org-macro.el 
(source)...
Loading /home/stardiviner/Code/Emacs/org-mode/testing/lisp/test-org-macs.el 
(source)...
Loading /home/stardiviner/Code/Emacs/org-mode/testing/lisp/test-org-num.el 
(source)...
Loading 
/home/stardiviner/Code/Emacs/org-mode/testing/lisp/test-org-pcomplete.el 
(source)...
Loading /home/stardiviner/Code/Emacs/org-mode/testing/lisp/test-org-protocol.el 
(source)...
Loading /home/stardiviner/Code/Emacs/org-mode/testing/lisp/test-org-src.el 
(source)...
Loading /home/stardiviner/Code/Emacs/org-mode/testing/lisp/test-org-table.el 
(source)...
Loading /home/stardiviner/Code/Emacs/org-mode/testing/lisp/test-org-tempo.el 
(source)...
Loading /home/stardiviner/Code/Emacs/org-mode/testing/lisp/test-org-timer.el 
(source)...
Loading /home/stardiviner/Code/Emacs/org-mode/testing/lisp/test-org.el 
(source)...
Loading /home/stardiviner/Code/Emacs/org-mode/testing/lisp/test-ox-publish.el 
(source)...
Loading /home/stardiviner/Code/Emacs/org-mode/testing/lisp/test-ox.el 
(source)...
Loading 
/home/stardiviner/Code/Emacs/org-mode/testing/lisp/test-property-inheritance.el 
(source)...
selected tests: test-org-core/dir-mkdirp
Running 0 tests (2019-03-02 12:24:25+0800, selector 
‘"test-org-core/dir-mkdirp"’)

Ran 0 tests, 0 results as expected (2019-03-02 12:24:25+0800, 0.000297 sec)

make cleantest
make[1]: Entering directory '/home/stardiviner/Code/Emacs/org-mode'
rm -fr /tmp/tmp-orgtest || { \
  find /tmp/tmp-orgtest -type d -exec chmod u+w {} + && \
  rm -fr /tmp/tmp-orgtest ; \
}
make[1]: Leaving directory '/home/stardiviner/Code/Emacs/org-mode'
#+end_example


-- 
[ stardiviner ]
       I try to make every word tell the meaning what I want to express.

       Blog: https://stardiviner.github.io/
       IRC(freenode): stardiviner, Matrix: stardiviner
       GPG: F09F650D7D674819892591401B5DF1C95AE89AC3