[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Removing obsolete function `org-truely-invisible-p'.
From: |
Samuel Wales |
Subject: |
Re: Removing obsolete function `org-truely-invisible-p'. |
Date: |
Sat, 4 Dec 2021 15:19:27 -0700 |
idk and will go along with whatever developers decide, but your note
was a good reminder that visible mode can be checked.
also made me wonder if it is possible to move anything from org-macs
out to topic-specific files like org-visibility.el or so? no?
[idk what org visibility functions do what. although i suspect org
can do it, i still use htmlize-buffer-substring-no-invisible.]
On 12/4/21, Karl Fogel <kfogel@red-bean.com> wrote:
> The function `org-truely-invisible-p' is defined in
> 'lisp/org-macs.el', but it is not used anywhere anymore in Org
> Mode, nor is it used anywhere in GNU Emacs (I checked on both
> 'emacs-28' branch and 'master' branch).
>
> The last (and possibly only?) call to that function was removed
> from `org-beginning-of-line' in this commit:
>
> commit 3baf246f4f73005a4eacd7c368f7222f95d50243
> Author: Nicolas Goaziou <mail@nicolasgoaziou.fr>
> AuthorDate: Thu Apr 28 23:28:15 2016 +0200
> Commit: Nicolas Goaziou <mail@nicolasgoaziou.fr>
> CommitDate: Thu Apr 28 23:28:15 2016 +0200
>
> Handle correctly `shift-select-mode'
>
> * lisp/org.el (org-beginning-of-line): Handle correctly
> `shift-select-mode'.
>
> Reported-by: Mathieu Marques <mathieumarques78@gmail.com>
> <http://permalink.gmane.org/gmane.emacs.orgmode/106783>
>
> Then, a few months later in commit 87116700e6e, Nicholas moved the
> function to 'org-macs.el', where it has been sitting unused ever
> since.
>
> Should we just remove `org-truely-invisible-p'? Or at least
> correct the spelling of its name ("truely" should be "truly")?
>
> It seems fairly unlikely to me that people are using it in their
> own code, although of course I cannot be sure of that. Partly, I
> believe that because surely someone else would have noticed the
> misspelling by now, if enough people were using it :-).
>
> Best regards,
> -Karl
>
>
--
The Kafka Pandemic
A blog about science, health, human rights, and misopathy:
https://thekafkapandemic.blogspot.com