Re: [PATCH v2] Re: Adding target and custom id links doesn't ask for description

[Max Nikulin]

On 12/09/2022 18:02, Ihor Radchenko wrote:
> Max Nikulin writes:
>
> > Unfortunately, your patch does not fix the real issue. The title (not
> > nil) should be saved for link description when the heading contains the
> > CUSTOM_ID property. I tried to address it in the following patches:
> >
> > Max Nikulin. Re: Bug: org-store-link uses CUSTOM_ID instead of target
> > point. Sat, 6 Nov 2021 19:51:29 +0700.
> > https://list.orgmode.org/e2c807a7-1924-6f08-9e63-4f70aee9d3b5@gmail.com
>
> Does it mean that my patch + the patch you linked can be used to fix the
> issue reported in this thread?

To fix the #custom_id issue it is enough to commit 2 patches from the 
linked thread: reverting the change caused duplication of stored 
#custom_id links and an alternative fix to store link to <<target>>.

As to <<target>> links, I am unsure what description should be stored 
for <<target>>. I do not think it should be heading title and I do not 
like /full/path/file.org::target that looks strange when file is 
stripped for a link to the same file, but description contains full 
path. I proposed (3rd patch) to store just "target" as description, you 
may prefer nil. Both approaches allows to bypass broken auto-desc logic 
(which I would like to remove) and to show the prompt for description.

I consider your patch as a general improvement because it allows to 
avoid description = link in more cases.