[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [patch] ob-clojure: Fix results output
From: |
Ihor Radchenko |
Subject: |
Re: [patch] ob-clojure: Fix results output |
Date: |
Thu, 23 Mar 2023 11:52:05 +0000 |
Daniel Kraus <daniel@kraus.my> writes:
> Ihor Radchenko <yantar92@posteo.net> writes:
>
>> Now, the docstring appears to be a bit confusing:
>>
>> (defun ob-clojure-eval-with-cider (expanded _params &optional cljs-p)
>> "Evaluate EXPANDED code block with PARAMS using cider.
>> When CLJS-P is non-nil, use a cljs connection instead of clj."
>>
>> It would be useful to mention that PARAMS argument is unused.
>
> Should I go with your initial suggestion and just replace it with _?
> Like
>
> (defun ob-clojure-eval-with-cider (expanded _ &optional cljs-p)
> "Evaluate EXPANDED code block using cider.
> When CLJS-P is non-nil, use a cljs connection instead of clj."
>
> But then someone will maybe wonder why there is unused argument?
>
> Or rather something like:
>
> (defun ob-clojure-eval-with-cider (expanded _params &optional cljs-p)
> "Evaluate EXPANDED code block using cider.
> When CLJS-P is non-nil, use a cljs connection instead of clj.
> The PARAMS from Babel are not used in this function."
I like the second variant better.
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
- Re: [patch] ob-clojure: Fix results output, (continued)
- Re: [patch] ob-clojure: Fix results output, Ihor Radchenko, 2023/03/14
- Re: [patch] ob-clojure: Fix results output, Daniel Kraus, 2023/03/14
- Re: [patch] ob-clojure: Fix results output, Daniel Kraus, 2023/03/14
- Re: [patch] ob-clojure: Fix results output, Ihor Radchenko, 2023/03/15
- Re: [patch] ob-clojure: Fix results output, Daniel Kraus, 2023/03/15
- Re: [patch] ob-clojure: Fix results output, Ihor Radchenko, 2023/03/16
- Re: [patch] ob-clojure: Fix results output, Ihor Radchenko, 2023/03/19
- Re: [patch] ob-clojure: Fix results output, Daniel Kraus, 2023/03/19
- Re: [patch] ob-clojure: Fix results output, Ihor Radchenko, 2023/03/22
- Re: [patch] ob-clojure: Fix results output, Daniel Kraus, 2023/03/23
- Re: [patch] ob-clojure: Fix results output,
Ihor Radchenko <=
- Re: [patch] ob-clojure: Fix results output, Daniel Kraus, 2023/03/23