Re: [PATCH] In case of Sly, let org-babel-execute:lisp use Slynk instead of Swank

[gerard . vermeulen]

On 29.03.2023 11:42, Ihor Radchenko wrote:
> gerard.vermeulen@posteo.net writes:
>
> > The Emacs integrated development environments Slime and Sly
> > communicate by means of similar RPC protocols with different server
> > programs: Swank in case of Slime and Slynk in case of Sly.  However,
> > the code in org-babel-execute:lisp always expects to talk with Swank
> > because of the hard-coded call to swank:eval-and-grab-output.
> >
> > After starting a Sly REPL, calls to swank:eval-and-grab-output do not
> > talk with the Slynk server started by the Sly REPL.
> >
> > The attached patch "soft-codes" eval-and-grab-output to become
> > swank:eval-and-grab-output when using Slime and
> > slynk:eval-and-grab-output when using Sly.
>
> I do not use ob-lisp, but this patch looks reasonable.
>
> I'd appreciate if other ob-lisp users could test the patch with both 
> SLY
> and SLIME.
>
> I have no comments on the Elisp part of the patch.

I have a few additional remarks:

The patch is against main only because it overlaps a region where bugfix
and main diverged.  I am willing to provide a similar patch against 
main.

I have installed Slime and Sly with the same user-emacs-directory using
package-install.  Normally, both autoload when doing M-x sly, but Sly
prompts you whether you want to disable Slime.  I choose "yes" to test
Sly.  I package-delete Sly when I want to test Slime.

See https://github.com/joaotavora/sly/blob/master/CONTRIBUTING.md
describes in detail how Sly uses the RPC protocol.

I hope that my mail reaches David (CC-ed dto@gnu.org  taken from the
file header), but my previous message bounced (non-existent address).

Best regards -- Gerard