[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Bug report for ox-icalendar: newlines should be CRLF
From: |
Jack Kamm |
Subject: |
Re: Bug report for ox-icalendar: newlines should be CRLF |
Date: |
Fri, 14 Apr 2023 09:38:18 -0700 |
<tomas@tuxteam.de> writes:
>> > There is a related issue about EOLs, not just \r\n -- each line should
>> > be a maximum of 75 characters; this is handled by
>> > org-icalendar-fold-string
>>
>> May you please provide a link to the iCalendar spec document section
>> describing this requirement?
>
> It's in rfc5545 [1], referenced to from rfc7986 [2].
Since VEVENT and VTODO are wrapped in `org-icalendar-fold-string', I
think the only place this error may occur is in the preamble created by
`org-icalendar--vcalendar', e.g. in PRODID, X-WR-CALDESC, etc.
The fix is to move the call to `org-icalendar-fold-string' out of
org-icalendar--vevent/vtodo, and instead put it in
`org-icalendar--vcalendar'. Then the line folding will apply to the
whole VCALENDAR instead of just the VTODO and VEVENT. An earlier version
of my CRLF patch actually did something like this.
I can push such a fix over the weekend. Let me know if you'd rather I
send the patch for review here first.