[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[BUG] ob-R tests fail on Emacs 27 since ESS commit 536b5b914a7 [9.7-pre
From: |
Ihor Radchenko |
Subject: |
[BUG] ob-R tests fail on Emacs 27 since ESS commit 536b5b914a7 [9.7-pre (release_9.6.4-318-gcfe5e0.dirty @ /home/yantar92/.emacs.d/straight/build/org/)] |
Date: |
Mon, 17 Apr 2023 18:45:21 +0000 |
Steps to reproduce:
1. cd /path/to/org/git/repo
2. make test EMACS=emacs-27 BTEST_POST="-L /path/to/ESS/lisp -l ob-R -l ess -l
ess-r-mode" BTEST_RE="async"
3 unexpected results:
FAILED ob-session-async-R-named-output
FAILED ob-session-async-R-output-drawer
FAILED ob-session-async-R-simple-session-async-output
The tests started failing since 2023/04/04.
https://builds.sr.ht/~bzg/job/968099
I bisected the failure down to the following ESS commit:
536b5b914a75afa37ee05aa8ba0aecd0f9c9eb33
Author: Lionel Henry <lionel.hry@gmail.com>
AuthorDate: Mon Apr 3 13:01:11 2023 +0200
Commit: Lionel Henry <lionel.hry@gmail.com>
CommitDate: Mon Apr 3 13:01:11 2023 +0200
Parent: fef059c3 Wait for process after `ess-r-post-run-hook`
Contained: master
Follows: ESSRv1.8 (21)
Move `ess-r` startup commands out of `ess-r-post-run-hook`
They are blocking commands and the user might have added streaming
commands to the hook.
Also document why users should be careful when mixing blocking and
streaming commands.
------
I am not sure what is going on as ob-R does not really use the changed
hooks. The suspects are
(ess-execute-screen-options t)
(ess-set-working-directory default-directory)))
In particular, I think that `ess-execute-screen-options' is doing
something funny because one of the tests fails with
"1:5" outputting
1 2 3
4 5
split into two lines, which looks like some text filling problem.
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
- [BUG] ob-R tests fail on Emacs 27 since ESS commit 536b5b914a7 [9.7-pre (release_9.6.4-318-gcfe5e0.dirty @ /home/yantar92/.emacs.d/straight/build/org/)],
Ihor Radchenko <=