Re: [ANN] lisp/ob-tangle-sync.el

[Ihor Radchenko]

Mehmet Tekman <mtekman89@gmail.com> writes:

>> 3. Please do not use private functions from third-party libraries. I am
>>    talking about `cl--set-buffer-substring' in particular.
>>
>
> So initially I used `(setf (buffer-substring X Y) new-content)` but I
> recieved a warning from Emacs that it was an obsolete generalized
> variable.

Yup. See https://yhetil.org/emacs-devel/87tu5fzu2r.fsf@localhost/
We need to do things manually.

> After some searching I found this entry in an emacs fork used the cl
> library:
>   
> https://github.com/emacs-citar/citar/commit/809953a2191d0e3217ffbed9270be9b3cd6abfd2
>
> Since `(require 'cl-lib)' is already imported in ~ob-tangle.el~, I did
> not think it was too taboo to use.

Private functions are a subject of change without notice. That's why we
do not use them, unless they are _our_ private functions we have control
about.

> How does one then set the buffer substring?

`replace-region-contents'.

> Apologies. I rebased and squashed all my commits into one, and then
> selectively staged hunks into seperate commits for the git format-patc
> process.  For some reason the diff function decided that the new
> functions should exist right in the middle of an existing function and I
> was not sure how to resolve it at the time (though I have a better idea
> now).

Interactive rebase is helpful.
You can also edit, reset files, or apply patches in the middle of
rebasing to do extra adjustments.

> I will take better care with the messages. I tried to look for previous
> "[ANN]" postings in the mailing list that I could emulate, but didn't
> pay enough attention it seems.

Just try to follow what we usually do in commit messages. See
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/log/
Also, see https://www.gnu.org/prep/standards/html_node/Change-Logs.html
and https://git.savannah.gnu.org/cgit/emacs.git/plain/CONTRIBUTE

> I'm finally using `gnus' as my mail client so I'm slowly getting into a
> more streamlined mindset that should be better at submitting and
> formatting patches. (To reply to a mailing list, I do a wide reply to
> the author and hope that the `Mail-Followup-To' header is used?)

Reply all, or wide reply should be the right way. We do not want to
exclude participants who are not subscribed to the mailing list.

> Apropos patches:
> Given how broken my current patches are, my next set of changes will be
> not contingent on the previous ones. I will start a new set of patches.
> I hope that's okay.

A common approach is changing subject to [PATCH v2] ...
You can also use so-called reroll count when generating patchset from
git (or magit).

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>