[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] testing: Delete duplicate tests
From: |
Ihor Radchenko |
Subject: |
Re: [PATCH] testing: Delete duplicate tests |
Date: |
Sat, 15 Jul 2023 07:56:16 +0000 |
Max Nikulin <manikulin@gmail.com> writes:
> The idea to find duplicated tests is bright. The code may be transformed
> in a dedicated unit test. I would not drop existing tests blindly though.
Very good idea indeed.
One gotcha is that not every should form is next level after
ert-deftest. And there are also "should-not" and "should-error" forms.
So, we may compare only forms at the same sexp depth for equality,
without restricting to "should".
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>