Re: [PATCH] Testing: Add tests for 'org-agenda-check-for-timestamp-as-reason-to-ignore-todo-item'

[Ihor Radchenko]

Morgan Smith <Morgan.J.Smith@outlook.com> writes:

> * testing/lisp/test-org-agenda.el
> (test-org-agenda/check-for-timestamp-as-reason-to-ignore-todo-item):
> New test.

Thanks for the patch, but I am not sure if what we want to test is this
function.

`org-agenda-check-for-timestamp-as-reason-to-ignore-todo-item' is
semi-internal function, which is simply serving to group some common
skip tests together.

It will be more reliable to test the final agenda behaviour - what is
display in the actual agenda view and what not.
Basically, instead of testing the return value of
`org-agenda-check-for-timestamp-as-reason-to-ignore-todo-item', test
using `org-test-agenda-with-agenda' and check the agenda buffer
contents.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>