Re: [PATCH] Testing: Ensure 'org-id-locations-file' is set before updating

[Ihor Radchenko]

Morgan Smith <Morgan.J.Smith@outlook.com> writes:

> Previously, when trying to run the tests in a container limited to the
> org repository, it fails because it can't create the directory
> "~/.emacs.d/.org-id-locations".
>
> * testing/org-test.el (org-test-load): Move setting
> 'org-id-locations-file' from here ...
> org-test-update-id-locations: ... to here
> ---
>
> Hello!  This fix allows me to run the tests without giving it access to the
> filesystem outside of the repository.  I have no clue what org-id-locations 
> are
> and I'm hoping someone else does so I don't have to learn.  I'm not sure if
> this is the best fix, but it works.

The whole

(defconst org-test-dir
  (expand-file-name (file-name-directory (or load-file-name buffer-file-name))))

is fishy when users attempt to run tests from normal Emacs session.

If you had issues with this variable from batch invocation, something
should be fixed in the defconst, I think.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>