|
From: | Max Nikulin |
Subject: | Re: [PATCH] ob-sqlite: Use a transient in-memory database by default |
Date: | Sat, 12 Aug 2023 16:38:04 +0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 |
On 06/08/2023 07:22, Rudolf Adamkovič wrote:
* lisp/ob-sqlite.el (org-babel-execute:sqlite): Default ':db' to ":memory:" instead of throwing an error.
This commit message entry does not reflect changed approach clearly enough. Not passing :db is a bit different from default :memory:. Sorry that I have not noticed it earlier. Since the commit has been pushed, I do not expect any further action in response.
@@ -97,7 +96,7 @@ This function is called by `org-babel-execute-src-block'." (member :html others) separator) "" "-csv")) - (cons "db " db))) + (cons "db" (or db ""))))
My expectation was that sqlite3 should print a warning, but actually it does not.
echo "select 1" | sqlite3 1 sqlite3 SQLite version 3.31.1 2020-01-27 19:55:54 Enter ".help" for usage hints. Connected to a transient in-memory database. Use ".open FILENAME" to reopen on a persistent database.In this sense I would prefer the previous version of the patch, but I admit, it is my fault that I did not tried it despite a week passed.
[Prev in Thread] | Current Thread | [Next in Thread] |