[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Move files when using org-babel-tangle-publish

From: Antero Mejr
Subject: Re: [PATCH] Move files when using org-babel-tangle-publish
Date: Fri, 08 Dec 2023 23:08:07 +0000

Ihor Radchenko <yantar92@posteo.net> writes:

> Also, may I know if you have an FSF copyright assignment? If not, you
> also need to add TINYCHANGE to the commit message - see
> https://orgmode.org/worg/org-contribute.html#first-patch

Yes I have assigned copyright to the FSF already.

> May you please submit a patch against Org mode git repository -
> https://git.savannah.gnu.org/cgit/emacs/org-mode.git, as described at
> https://orgmode.org/worg/org-contribute.html ?
> Please quote `rename-file' and `copy-file' like I do - it is our commit
> message convention (https://orgmode.org/worg/org-contribute.html#orgd7441de)
>> -  (mapc (lambda (el) (copy-file el pub-dir t)) (org-babel-tangle-file 
>> filename)))
>> +  (mapc (lambda (el) (rename-file el pub-dir t))
>> +        (org-babel-tangle-file filename)))
> I think that it would be nice to add a brief comment why `rename-file'
> to the code as well.  `copy-file' looks innocent there from a first
> glance.

Fixed in attached patch.

Attachment: 0001-Move-files-when-using-org-babel-tangle-publish.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]