emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Connecting to an Already Running Scheme REPL with org-babel


From: Hunter Jozwiak
Subject: Re: Connecting to an Already Running Scheme REPL with org-babel
Date: Mon, 29 Jan 2024 14:10:30 -0500




On Mon, Jan 29, 2024 at 8:15 AM Ihor Radchenko <yantar92@posteo.net> wrote:
Hunter Jozwiak <hunter.t.joz@gmail.com> writes:

>   Here is a patch that provides this functionality.

Thank you!

> Subject: [PATCH] org-mode: allow ob-scheme to accept a remote connection.
>
> * lisp/org/ob-scheme.el (org-babel-scheme-get-repl): introduce two
> optional variables  host  and port. If there are not given, just run
           ^^^^^^^^^ arguments

> * lisp/org/ob-scheme (org-babel-scheme-execute-with-geiser,
> org-babel-execute:scheme): take these  optional arguments into
> account.

... and add two new optional arguments.

> @@ -231,6 +235,8 @@ org-babel-execute:scheme
>                      geiser-scheme-implementation
>                      geiser-default-implementation
>                      (car geiser-active-implementations)))
> +             (host (cdr (assq :host params)))
> +             (port (cdr (assq :port params)))

Please declare these new scheme-specific header argument in
`org-babel-header-args:scheme'.
See `org-babel-header-args:C' for an example.
This is necessary for header argument completion to work.

Also, please document the new header argument in the ob-scheme
documentation at
https://orgmode.org/worg/org-contrib/babel/languages/ob-doc-scheme.html
(you can submit a patch against
https://git.sr.ht/~bzg/worg/tree/master/item/org-contrib/babel/languages/ob-doc-scheme.org )
Here is the worg patch.
> -            (and (not (string= session "none")) session)))) ; session
> +            (and (not (string= session "none")) session)  host port))) ; session

This does not look right. Your change will disable session support
completely when host and port are not provided.

--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Attachment: 0001-ob-scheme-document-the-new-header-arguments.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]