emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Cannot yank media when image come from Gnome screenshot


From: Ihor Radchenko
Subject: Re: Cannot yank media when image come from Gnome screenshot
Date: Mon, 05 Aug 2024 17:44:43 +0000

Robert Pluim <rpluim@gmail.com> writes:

>>>>>> On Sun, 04 Aug 2024 19:01:24 +0000, Ihor Radchenko <yantar92@posteo.net> 
>>>>>> said:
>
>     Ihor> I am not sure if I like patching Emacs functions when loading Org 
> mode.
>     Ihor> On the other hand, I do not see any obvious downside.
>
> I was hoping youʼd have a strong opinion 😀

Generally speaking, defining global methods is a very bad practice.
But I feel that it _might_ be justified in this particular case.

>     Ihor> Robert, what do you think about such idea? 
>
> Itʼs a cl-defmethod that I assume you will hide behind a version
> check, and the changed code itself should only run for a pgtk emacs,
> so I donʼt see a great risk. And in the absolute worst case
> `yank-media' doesnʼt work, which is the situation we already have.

Yes, behind version check, pgtk build check, and, ideally, after
checking that such method is not yet defined.
May you create such a patch against Org mode repository?

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]