Re: 4 week-old pretest bugs

[Chris Moore]

Jan Djärv <address@hidden> writes:

> Thanks.  Somehow the thread detection thingy isn't working
> correctly.  While I try to figure this out, please try the patch
> suggested by YAMAMOTO Mitsuharu.

That patch didn't appear to make any difference, but I've found one
that fixes the bug for me.

I have no idea why it works, but it does really seem to:

------------------------------------------------------------------------
--- src/blockinput.h    2007-01-10 18:22:43.000000000 +0100
+++ src/new/blockinput.h        2007-01-10 18:18:18.000000000 +0100
@@ -61,8 +61,10 @@
 
 extern int pending_atimers;
 
+static int mytmp;
+
 /* Begin critical section. */
-#define BLOCK_INPUT (interrupt_input_blocked++)
+#define BLOCK_INPUT (mytmp++, interrupt_input_blocked++)
 
 /* End critical section.
 
------------------------------------------------------------------------

I suppose this must be indicitive of some kind of race condition,
since the mytmp++ doesn't do anything but delay the increment of
interrupt_input_blocked by a very short amount of time.

Chris.