[emms-help] Re: [Emms-patches] darcs patch: use-existing-functionality-for-renaming-... (and 4 more)

[Michael Olson]

Nix <address@hidden> writes:

> On 19 Aug 2007, Michael Olson outgrape:
>> Additionally, I tried evaluating (featurep 'overlay) before
>> evaluating (require 'emms-playlist-mode) and afterward.  The results
>> were nil and t, respectively.
>
> That might be because you hadn't byte-compiled emms-playlist-mode.el
> (or at least not with the XEmacs byte-compiler). `eval-when-compile'
> has somewhat strange semantics: the body is executed when the
> byte-compiler processes the form *or* when the form is read by the
> interpreter, but not when an .elc is loaded at runtime. (This is
> easily verifiable with a one-line testcase. Try executing
> (eval-when-compile (message "foo")), then byte-compiling it and
> loading the resulting .elc, and watch the ` *Message-Log*' buffer.)
>
> I'd say you really do want `eval-and-compile' here, but since you're
> only doing a `require' which has those semantics anyway, this reduces
> to a plain `require'.

Yeah, I didn't byte-compile the source before testing, so that's why I
never saw the problem.  I've sent in a patch that drops the
eval-when-compile part.  Thanks!

-- 
       Michael Olson -- FSF Associate Member #652     |
 http://mwolson.org/ -- Jabber: mwolson_at_hcoop.net  |  /` |\ | | |
            Sysadmin -- Hobbies: Lisp, GP2X, HCoop    | |_] | \| |_|
Projects: Emacs, Muse, ERC, EMMS, ErBot, DVC, Planner |

pgpD7KJTKvMgJ.pgp
Description: PGP signature