[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Patch] Add: warning when no tag writer exists
From: |
Yoni Rabkin |
Subject: |
Re: [Patch] Add: warning when no tag writer exists |
Date: |
Mon, 03 May 2021 16:29:05 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Grant Shoshin Shangreaux <grant@churls.world> writes:
> Yoni Rabkin writes:
>
>> Grant Shoshin Shangreaux <grant@churls.world> writes:
>>
>>> +(defun emms-tag-editor--track-editable-p (track)
>>> + "Return t if TRACK is not a file, or has a tagfile function defined."
>>> + (or (not (emms-track-file-p track))
>>> + (emms-tag-editor--tagfile-function track)))
>>
>> Why check if it is a file? Not all files are editable (e.g. .pls, .m3u).
>
> Oh, good point. This was to allow editing of URL tracks for example. I
> just assumed if the track isn't a file we can allow adding metadata to
> the cache-db if desired. We're not trying to write to any file so just
> allow it as editable. If it /is/ a file then we check for a tagfile
> function. Considering we won't have one defined for .pls or .m3u this
> should catch those, correct?
It is a roundabout way of addressing it, but perfectly valid. It can
stay that way.
--
"Cut your own wood and it will warm you twice"
- [Patch] Add: warning when no tag writer exists, Grant Shoshin Shangreaux, 2021/05/01
- Re: [Patch] Add: warning when no tag writer exists, Yoni Rabkin, 2021/05/02
- Re: [Patch] Add: warning when no tag writer exists, Yoni Rabkin, 2021/05/03
- Re: [Patch] Add: warning when no tag writer exists, Yoni Rabkin, 2021/05/04
- Re: [Patch] Add: warning when no tag writer exists, Alexis, 2021/05/05
- Re: [Patch] Add: warning when no tag writer exists, Yoni Rabkin, 2021/05/05