[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Add: tracktag interface and support for Opus
From: |
Yoni Rabkin |
Subject: |
Re: [PATCH] Add: tracktag interface and support for Opus |
Date: |
Sun, 23 May 2021 19:08:41 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Grant Shoshin Shangreaux <grant@churls.world> writes:
> Yoni Rabkin writes:
>
>> Beforehand, please have a look at the circular dependency you have
>> between emms-tag-editor and emms-tag-tracktag:
>> `emms-tag-editor-log-buffer' is defined in emms-tag-editor.el, but
>> emms-tag-editor requires emms-tag-tracktag.
>
> i just added an additional var for emms-tag-tracktag for the time
> being. the existing api for calling the tag writer function could be
> changed to accept a log buffer argument, but i thought i'd ask about
> that before making further changes.
That works; thanks.
I hope to get to work with the opus code more this week, and then we can
merge it.
--
"Cut your own wood and it will warm you twice"
Re: [PATCH] Add: tracktag interface and support for Opus, Grant Shoshin Shangreaux, 2021/05/08
Re: [PATCH] Add: tracktag interface and support for Opus, Petteri Hintsanen, 2021/05/25