emms-help
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: A couple small patches


From: Yoni Rabkin
Subject: Re: A couple small patches
Date: Tue, 17 Oct 2023 14:45:56 -0400
User-agent: Gnus/5.13 (Gnus v5.13)

Morgan Smith <Morgan.J.Smith@outlook.com> writes:

> Hello!
>
> I have a couple tiny patches that are hopefully all self explanatory.
> Let me know what you think.

I've applied all three. I personally don't like doing work in a :set
function, but I understand that it's a perfectly valid way of doing
things (and that I'm an old curmudgeon). The Elisp manual says that:

     """ If you specify this keyword [:set], the variable’s
     documentation string should describe how to do the same job in
     hand-written Lisp code, either by invoking SETFUNCTION directly or
     by using ‘setopt’."""

No need to do that in this case, but it underlines why I'm generally
wary of splitting code between functions and customizable variables.

Thank you for your patches!

-- 
   "Cut your own wood and it will warm you twice"



reply via email to

[Prev in Thread] Current Thread [Next in Thread]