[Emms-patches] darcs patch: emms-player-mpd: Implement seek-to support (and 4 more)

[Michael Olson]

Tue Oct 17 16:51:06 EDT 2006  Michael Olson <address@hidden>
  * emms-player-mpd: Implement seek-to support

Tue Oct 17 16:53:10 EDT 2006  Michael Olson <address@hidden>
  * emms-browser: Fix compiler warning

Tue Oct 17 17:02:38 EDT 2006  Michael Olson <address@hidden>
  * Since emms-player-seeked-to-functions and emms-player-time-set-functions 
hooks do the same thing, replace the former with the latter

Tue Oct 17 17:53:45 EDT 2006  Michael Olson <address@hidden>
  * Documentation cleanups in emms-player-mpd and emms-source-playlist

Tue Oct 17 18:04:04 EDT 2006  Michael Olson <address@hidden>
  * emms-player-mpd: When using the emms-volume interface, allow the user to 
specify the amount of change in the volume

New patches:

[emms-player-mpd: Implement seek-to support
Michael Olson <address@hidden>**20061017205106] {
hunk ./emms-player-mpd.el 227
+(emms-player-set emms-player-mpd
+                 'seek-to
+                 'emms-player-mpd-seek-to)
+
hunk ./emms-player-mpd.el 879
+(defun emms-player-mpd-seek-to (pos)
+  "Seek to POS seconds from the start of the current track."
+  (interactive)
+  (emms-player-mpd-get-current-song
+   pos
+   (lambda (pos song)
+     (when (and song pos)
+       (emms-player-mpd-send
+        (concat "seek " song " " (number-to-string pos))
+        nil #'ignore)))))
+
}

[emms-browser: Fix compiler warning
Michael Olson <address@hidden>**20061017205310] {
hunk ./emms-browser.el 1109
-            parent-data parent-point)
+            parent-bdata parent-point)
}

[Since emms-player-seeked-to-functions and emms-player-time-set-functions hooks 
do the same thing, replace the former with the latter
Michael Olson <address@hidden>**20061017210238] {
hunk ./emms-playing-time.el 120
-       (add-hook 'emms-player-seeked-to-functions 'emms-playing-time-set)
hunk ./emms.el 222
-(defcustom emms-player-seeked-to-functions nil
-  "*Functions called when a player is seeking.
-The functions are called with a single argument, the amount of
-seconds the player seeked to."
-  :group 'emms
-  :type 'hook)
-
hunk ./emms.el 1345
-        (run-hook-with-args 'emms-player-seeked-to-functions seconds)))))
+        (run-hook-with-args 'emms-player-time-set-functions seconds)))))
}

[Documentation cleanups in emms-player-mpd and emms-source-playlist
Michael Olson <address@hidden>**20061017215345] {
hunk ./emms-player-mpd.el 121
+
hunk ./emms-player-mpd.el 158
-  "Formats supported by MusicPD Client."
+  "Formats supported by MusicPD."
hunk ./emms-player-mpd.el 317
+
hunk ./emms-player-mpd.el 327
+
hunk ./emms-player-mpd.el 337
+
hunk ./emms-player-mpd.el 363
+
hunk ./emms-player-mpd.el 376
+
hunk ./emms-player-mpd.el 392
+
hunk ./emms-player-mpd.el 656
-If an error occurs, display a relevant message.
+Execute CALLBACK with CLOSURE as its first argument when done.
hunk ./emms-player-mpd.el 658
-Execute CALLBACK with CLOSURE as its first argument when done."
+If an error occurs, display a relevant message."
hunk ./emms-player-mpd.el 675
-This handles both m3u and pls type playlists.
+Execute CALLBACK with CLOSURE as its first argument when done.
hunk ./emms-player-mpd.el 677
-Execute CALLBACK with CLOSURE as its first argument when done."
+This handles both m3u and pls type playlists."
hunk ./emms-player-mpd.el 687
-This handles both m3u and pls type playlists.
+Execute CALLBACK with CLOSURE as its first argument when done.
hunk ./emms-player-mpd.el 689
-Execute CALLBACK with CLOSURE as its first argument when done."
+This handles both m3u and pls type playlists."
hunk ./emms-player-mpd.el 697
-
hunk ./emms-player-mpd.el 708
-
hunk ./emms-player-mpd.el 723
-
hunk ./emms-player-mpd.el 733
-
hunk ./emms-player-mpd.el 820
+
hunk ./emms-player-mpd.el 970
-If INSERTP is non-nil, insert the description into the current buffer instead.
-If CALLBACK is a function, call it with the current buffer and description.
+
+If INSERTP is non-nil, insert the description into the current
+buffer instead.
+
+If CALLBACK is a function, call it with the current buffer and
+description.
+
hunk ./emms-player-mpd.el 1013
-This is a useful addition to `emms-info-functions'.
hunk ./emms-player-mpd.el 1014
-info from MusicPD."
+info from MusicPD.
+
+This is a useful addition to `emms-info-functions'."
hunk ./emms-player-mpd.el 1037
+
hunk ./emms-player-mpd.el 1051
+
hunk ./emms-player-mpd.el 1077
+
hunk ./emms-source-playlist.el 242
-  "Return non-nil if the current buffer contains a native EMMS playlist."
+  "Return non-nil if the current buffer contains an m3u playlist.
+
+We currently have no metric for determining whether a buffer is
+an .m3u playlist based on its contents alone, so we assume that
+the more restrictive playlist formats have already been
+detected and simply return non-nil always."
hunk ./emms-source-playlist.el 251
-  "Parse the native EMMS playlist in the current buffer."
+  "Parse the m3u playlist in the current buffer."
hunk ./emms-source-playlist.el 259
-  "Extract a list of filenames from the given .m3u playlist.
+  "Extract a list of filenames from the given m3u playlist.
+
hunk ./emms-source-playlist.el 271
-IN should be a buffer with a EMMS playlist in it.
+IN should be a buffer containing an m3u playlist.
hunk ./emms-source-playlist.el 311
-  "Return non-nil if the current buffer contains a native EMMS playlist."
+  "Return non-nil if the current buffer contains a pls playlist."
hunk ./emms-source-playlist.el 319
-  "Parse the native EMMS playlist in the current buffer."
+  "Parse the pls playlist in the current buffer."
hunk ./emms-source-playlist.el 327
-  "Extract a list of filenames from the given .pls playlist.
+  "Extract a list of filenames from the given pls playlist.
+
hunk ./emms-source-playlist.el 339
-IN should be a buffer with a EMMS playlist in it.
+IN should be a buffer conatining a pls playlist.
}

[emms-player-mpd: When using the emms-volume interface, allow the user to 
specify the amount of change in the volume
Michael Olson <address@hidden>**20061017220404] {
hunk ./emms-player-mpd.el 188
+(defcustom emms-player-mpd-volume-change-amount 5
+  "The amount to use when raising or lowering the volume using the
+emms-volume interface.
+
+This should be a positive integer."
+  :type 'integer
+  :group 'emms-player-mpd)
+
hunk ./emms-player-mpd.el 201
-  :type 'integer
+  :type 'number
hunk ./emms-player-mpd.el 929
-  (emms-volume-mpd-change 5))
+  (emms-volume-mpd-change emms-player-mpd-volume-change-amount))
hunk ./emms-player-mpd.el 934
-  (emms-volume-mpd-change -5))
+  (emms-volume-mpd-change (- 0 emms-player-mpd-volume-change-amount)))
hunk ./emms.texinfo 1655
+
address@hidden emms-player-mpd-volume-change-amount
+The amount to use when raising or lowering the volume using the
+emms-volume interface.
+
+This should be a positive integer.
address@hidden defopt
}

Context:

[fix faulty emms-playlist-mode keybinding, fix due to William and Damien.
address@hidden 
[Added seeking to the playlist keymap, and updated the manual.
address@hidden 
[emms-player-mpd: Only display error if we are certain that url.el is not 
up-to-date
Michael Olson <address@hidden>**20061004032213] 
[seek-for-alsaplayer
address@hidden
 Add relative seek support for alsaplayer
] 
[midi-files-via-timidity
address@hidden
 A simple-player definition for timidity
] 
[emms-playing-time.el: Minor cleanups.
address@hidden 
[emms-lyrics.el: Minor Cleanups.
address@hidden 
[pause-for-alsaplayer
address@hidden
 Get pause/resume working for alsaplayer
] 
[mms-for-mplayer
address@hidden
 mplayer also supports mms:// URLs
] 
[DoTheRightThing with player pausing and emms-bookmarks.el
address@hidden 
[Added emms-bookmarks.el
address@hidden 
[Added `emms-pause' to emms-playlist-mode.el bound to to ``P''.
address@hidden 
[browser: add deletion started/finished message
Damien Elmes <address@hidden>**20060923051128] 
[Added a link to the online version of the manual.
address@hidden 
[emms-playing-time.el now works with `seek-to'.
address@hidden 
[Added `seek-to' to emms.el and emms-player-mplayer.el.
address@hidden 
[browser/cache: support deleting files, make emms-cache-dirty a defsubst
Damien Elmes <address@hidden>**20060922090553] 
[TAG 2.1
address@hidden 
Patch bundle hash:
fc9a355c51125e79bdd139ded8d3f8a23b27b860