[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emms-patches] EMMS Lyrics
From: |
William Xu |
Subject: |
Re: [Emms-patches] EMMS Lyrics |
Date: |
Tue, 13 Aug 2013 20:17:25 +0800 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (darwin) |
Ian D <address@hidden> writes:
> EMMS Developers,
>
> I noticed that EMMS will start redisplaying lyrics when it is
> paused. I looked into it, and noticed that the `timer-duration'
> function will remove any negative numbers, so in
> `emms-lyrics-set-timer', when the variable `time' is set, and is
> negative, when `run-at-time' is called, `timer-duration' changes it
> to a positive value, causing old lyrics to be displayed again.
> Setting a check for a positive value fixes this. The patch is
> attached.
Thanks. Fixed.
But below line should be outside `when', or it will freeze emacs.
> + (setq lyrics-alist (cdr lyrics-alist)))))))
--
William
http://xwl.appspot.com