emms-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Emms-patches] [PATCH] Avoids FLAC tags duplication with old values


From: Daniel Dehennin
Subject: [Emms-patches] [PATCH] Avoids FLAC tags duplication with old values
Date: Thu, 02 Jan 2014 10:49:56 +0100
User-agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.3.50 (gnu/linux)

The following changes since commit c10e28076ccec49828bd544fb2dda67c55bcdbc9:

  * lisp/emms-info-libtag.el: Added mp4, m4a to the extensions handled by 
emms-info-libtag (2013-10-16 12:32:47 -0400)

are available in the git repository at:

  git://git.baby-gnu.net/emms.git tags/hotfix/duplicated-flac-tags

for you to fetch changes up to 03b8b7678616a44781a95b8ae454e2fa67ac0b8f:

  emms-tag-editor-tag-flac do not replace tags (2014-01-02 10:27:25 +0100)

----------------------------------------------------------------
Avoids FLAC tags duplication with old values.

----------------------------------------------------------------
Daniel Dehennin (1):
      emms-tag-editor-tag-flac do not replace tags

 lisp/emms-tag-editor.el | 22 ++++++++++++++--------
 1 file changed, 14 insertions(+), 8 deletions(-)

diff --git a/lisp/emms-tag-editor.el b/lisp/emms-tag-editor.el
index 06041c5..2c28b96 100644
--- a/lisp/emms-tag-editor.el
+++ b/lisp/emms-tag-editor.el
@@ -143,19 +143,25 @@ See also `emms-tag-editor-tag-file' and 
`emms-tag-editor-tag-ogg'.")
   "Commit changes to an FLAC file according to TRACK."
   (require 'emms-info-metaflac)
   (with-temp-buffer
-    (let (need val)
+    (let ((tags '("artist" "composer" "performer" "title" "album" 
"tracknumber" "discnumber" "date" "genre" "note"))
+         need val)
       (mapc (lambda (tag)
               (let ((info-tag (intern (concat "info-" tag))))
                 (when (> (length (setq val (emms-track-get track info-tag))) 0)
                   (insert (upcase tag) "=" val "\n"))))
-            '("artist" "composer" "performer" "title" "album" "tracknumber" 
"discnumber" "date" "genre" "note"))
+            tags)
       (when (buffer-string)
-        (funcall #'call-process-region (point-min) (point-max)
-                 emms-info-metaflac-program-name nil
-                 (get-buffer-create emms-tag-editor-log-buffer)
-                 nil
-                 "--import-tags-from=-"
-                 (emms-track-name track))))))
+       (apply #'call-process-region (point-min) (point-max)
+                emms-info-metaflac-program-name nil
+                (get-buffer-create emms-tag-editor-log-buffer)
+                nil
+                (append
+                 (mapcar (lambda (tag)
+                           (concat "--remove-tag=" tag))
+                         tags)
+                 '("--import-tags-from=-")
+                 '("--")
+                 (list (emms-track-name track))))))))
 
 (defun emms-tag-editor-tag-ogg (track)
   "Commit changes to an OGG file according to TRACK."

-- 
Daniel Dehennin
Récupérer ma clef GPG:
gpg --keyserver pgp.mit.edu --recv-keys 0x7A6FE2DF

Attachment: pgpD3Dwr5QZuw.pgp
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]