erc-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Erc-commit] [commit][emacs22] capab-identify: Added a prefix face. Rena


From: mwolson
Subject: [Erc-commit] [commit][emacs22] capab-identify: Added a prefix face. Renamed two internal functions.
Date: Sun, 14 Oct 2007 00:48:50 -0400

commit 771131c78b26610410374991dfd56cf9b6865fba
Author: Diane Murray <address@hidden>
Date:   Sat Mar 10 16:51:18 2007 +0000

    capab-identify: Added a prefix face.  Renamed two internal functions.
    
    * erc-capab.el: Added more information to the Usage section.
    (erc-capab-identify-prefix): Doc fix.
    (erc-capab-identify-unidentified): New face.
    (290): Removed definition, moved to erc-backend.el.
    (erc-capab-identify-send-messages): Renamed from
    `erc-capab-send-identify-messages'.
    (erc-capab-identify-setup): Use it.
    (erc-capab-identify-add-prefix): Use
    `erc-capab-identify-get-unidentified-nickname'.  Use
    `erc-capab-identify-unidentified' as the face.
    (erc-capab-identify-get-unidentified-nickname): Renamed from
    `erc-capab-get-unidentified-nickname'.
    
    * erc-backend.el (290): Moved here from erc-capab.el.
    git-archimport-id: address@hidden/erc--main--0--patch-118

diff --git a/ChangeLog b/ChangeLog
index 98f1bb1..8faa2b7 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,4 +1,18 @@
-2007-03-05  Diane Murray  <address@hidden>
+2007-03-10  Diane Murray  <address@hidden>
+
+       * erc-capab.el: Added more information to the Usage section.
+       (erc-capab-identify-prefix): Doc fix.
+       (erc-capab-identify-unidentified): New face.
+       (290): Removed.  Definition moved to erc-backend.el.
+       (erc-capab-identify-send-messages): Renamed from
+       `erc-capab-send-identify-messages'.
+       (erc-capab-identify-setup): Use it.
+       (erc-capab-identify-get-unidentified-nickname): Renamed from
+       `erc-capab-get-unidentified-nickname'.
+       (erc-capab-identify-add-prefix): Use it.  Use
+       `erc-capab-identify-unidentified' as the face.
+
+       * erc-backend.el (290): Moved here from erc-capab.el.
 
        * erc.el (erc-select): Added an autoload cookie.
        (erc-message-type-member, erc-restore-text-properties): Use
diff --git a/erc-backend.el b/erc-backend.el
index e2b7914..08cb738 100644
--- a/erc-backend.el
+++ b/erc-backend.el
@@ -1513,6 +1513,9 @@ A server may send more than one 005 message."
 See `erc-display-server-message'." nil
   (erc-display-server-message proc parsed))
 
+(define-erc-response-handler (290)
+  "Handle dancer-ircd CAPAB messages." nil nil)
+
 (define-erc-response-handler (301)
   "AWAY notice." nil
   (erc-display-message parsed 'notice 'active 's301
diff --git a/erc-capab.el b/erc-capab.el
index 268c4bf..b7ccade 100644
--- a/erc-capab.el
+++ b/erc-capab.el
@@ -56,8 +56,10 @@
 ;; (erc-capab-identify-mode 1)
 
 ;; `erc-capab-identify-prefix' will now be added to the beginning of
-;; unidentified users' nicknames.  The default is an asterisk, "*".  If
-;; the value of this variable is nil or you disable this module (see
+;; unidentified users' nicknames.  The default is an asterisk, "*".
+;; You can customize the prefix and the face used to display it,
+;; `erc-capab-identify-unidentified'.  If the value of
+;; `erc-capab-identify-prefix' is nil or you disable this module (see
 ;; `erc-capab-identify-disable'), no prefix will be inserted, but the
 ;; flag sent by the server will still be stripped.
 
@@ -73,14 +75,19 @@
   :group 'erc)
 
 (defcustom erc-capab-identify-prefix "*"
-  "The prefix used for unidentified users."
+  "The prefix used for unidentified users.
+
+If you change this from the default \"*\", be sure to use a
+character not found in IRC nicknames to avoid confusion."
   :group 'erc-capab
   :type '(choice string (const nil)))
 
-;;; Define module:
+(defface erc-capab-identify-unidentified '((t)) ; same as `erc-default-face'
+  "Face to use for `erc-capab-identify-prefix'."
+  :group 'erc-capab
+  :group 'erc-faces)
 
-(define-erc-response-handler (290)
-  "Handle dancer-ircd CAPAB messages." nil nil)
+;;; Define module:
 
 ;;;###autoload (autoload 'erc-capab-identify-mode "erc-capab" nil t)
 (define-erc-module capab-identify nil
@@ -124,9 +131,9 @@ Optional argument PARSED is the current message, a response 
struct.
 These arguments are sent to this function when called as a hook in
 `erc-server-005-functions'."
   (unless erc-capab-identify-sent
-    (erc-capab-send-identify-messages)))
+    (erc-capab-identify-send-messages)))
 
-(defun erc-capab-send-identify-messages ()
+(defun erc-capab-identify-send-messages ()
   "Send CAPAB IDENTIFY messages if the server supports it."
   (when (and (stringp erc-server-version)
              (string-match "^\\(dancer-ircd\\|hyperion\\)" erc-server-version)
@@ -175,7 +182,7 @@ PARSED is an `erc-parsed' response struct."
   (when (and erc-capab-identify-prefix
              (erc-with-server-buffer erc-capab-identify-activated))
     (goto-char (or (erc-find-parsed-property) (point-min)))
-    (let ((nickname (erc-capab-get-unidentified-nickname
+    (let ((nickname (erc-capab-identify-get-unidentified-nickname
                      (erc-get-parsed-vector (point)))))
       (when (and nickname
                  (goto-char (point-min))
@@ -183,10 +190,9 @@ PARSED is an `erc-parsed' response struct."
                  (re-search-forward (regexp-quote nickname) nil t))
         (goto-char (match-beginning 0))
         (insert (erc-propertize erc-capab-identify-prefix
-                                'face (get-char-property (- (point) 1)
-                                                         'face)))))))
+                                'face 'erc-capab-identify-unidentified))))))
 
-(defun erc-capab-get-unidentified-nickname (parsed)
+(defun erc-capab-identify-get-unidentified-nickname (parsed)
   "Return the nickname of the user if unidentified.
 PARSED is an `erc-parsed' response struct."
   (when (and (erc-response-p parsed)




reply via email to

[Prev in Thread] Current Thread [Next in Thread]