Re: [Fab-user] Pull Request #766

[Rahul Menon]

+1 on Roy's Request

On Tue, Dec 11, 2012 at 8:36 PM, Roy Smith <address@hidden> wrote:

Speaking of pull requests, I'd really love to see https://github.com/fabric/fabric/pull/730 picked up.

Fab not reading the system ssh known_hosts file is a real problem for us.  We work in AWS.  New instances (and thus host keys) come up and down all the time.  We have a process in place to distribute host keys, but if fab doesn't see them, deployments break.

On Dec 11, 2012, at 9:58 AM, Todd DeLuca wrote:

Hi Jeff,

I created a simple pull request about a month ago ("Use task variable name when task name is undefined.", https://github.com/fabric/fabric/pull/766) and am eager to get the pull request accepted, since I actually use the functionality in some of my code.

I think it is a straightforward merge and a nice little improvement/bugfix to have in the code.  I imagine that you are terribly busy with many more important things, but I was hoping you could set my expectations for me.  

- Is there a chance of this request getting reviewed and accepted?  Perhaps it is irrelevant given your development roadmap.

- When should I start to get impatient and ping you?  A month, 6 months, never?

Given the comments in the Communcation section of the Development page (https://fabric.readthedocs.org/en/latest/development.html#communication), I'm not even sure that the Fabric devs are necessarily aware of my pull request.  

- Should I have created an Issue instead of a Pull Request?

Thanks for your attention.  And thanks especially for making Fabric amazing!

Regards,

Todd

--
Todd DeLuca
http://todddeluca.com

http://wall.hms.harvard.edu/

_______________________________________________
Fab-user mailing list
address@hidden
https://lists.nongnu.org/mailman/listinfo/fab-user

--

Roy Smith

address@hidden

_______________________________________________
Fab-user mailing list
address@hidden
https://lists.nongnu.org/mailman/listinfo/fab-user

--
- Rahul