fenfire-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[ff-cvs] fenfire/org/fenfire bin/fenpdf10.py fenpdf/BUGS...


From: Tuomas J. Lukka
Subject: [ff-cvs] fenfire/org/fenfire bin/fenpdf10.py fenpdf/BUGS...
Date: Fri, 15 Aug 2003 01:13:51 -0400

CVSROOT:        /cvsroot/fenfire
Module name:    fenfire
Branch:         
Changes by:     Tuomas J. Lukka <address@hidden>        03/08/15 01:13:51

Modified files:
        org/fenfire/bin: fenpdf10.py 
        org/fenfire/fenpdf: BUGS fenpdfcontext.py 
        org/fenfire/view: View2D.java 
        org/fenfire/view/buoy: AbstractMainNode2D.java 

Log message:
        More bugs

CVSWeb URLs:
http://savannah.gnu.org/cgi-bin/viewcvs/fenfire/fenfire/org/fenfire/bin/fenpdf10.py.diff?tr1=1.42&tr2=1.43&r1=text&r2=text
http://savannah.gnu.org/cgi-bin/viewcvs/fenfire/fenfire/org/fenfire/fenpdf/BUGS.diff?tr1=1.2&tr2=1.3&r1=text&r2=text
http://savannah.gnu.org/cgi-bin/viewcvs/fenfire/fenfire/org/fenfire/fenpdf/fenpdfcontext.py.diff?tr1=1.4&tr2=1.5&r1=text&r2=text
http://savannah.gnu.org/cgi-bin/viewcvs/fenfire/fenfire/org/fenfire/view/View2D.java.diff?tr1=1.8&tr2=1.9&r1=text&r2=text
http://savannah.gnu.org/cgi-bin/viewcvs/fenfire/fenfire/org/fenfire/view/buoy/AbstractMainNode2D.java.diff?tr1=1.43&tr2=1.44&r1=text&r2=text

Patches:
Index: fenfire/org/fenfire/bin/fenpdf10.py
diff -u fenfire/org/fenfire/bin/fenpdf10.py:1.42 
fenfire/org/fenfire/bin/fenpdf10.py:1.43
--- fenfire/org/fenfire/bin/fenpdf10.py:1.42    Thu Aug 14 08:13:03 2003
+++ fenfire/org/fenfire/bin/fenpdf10.py Fri Aug 15 01:13:51 2003
@@ -251,7 +251,7 @@
 # relation. 
 # XXX Should also check type.
 #
-iter = fen.constgraph.findN_X11_Iter(TREETIME.currentOf, TREETIME.follows)
+iter = fen.constgraph.findN_X11_Iter(TREETIME.firstOf, TREETIME.follows)
 planeHome = iter.next()
 if planeHome == None: 
     print "Error: home plane not found"
Index: fenfire/org/fenfire/fenpdf/BUGS
diff -u fenfire/org/fenfire/fenpdf/BUGS:1.2 fenfire/org/fenfire/fenpdf/BUGS:1.3
--- fenfire/org/fenfire/fenpdf/BUGS:1.2 Thu Aug 14 06:19:02 2003
+++ fenfire/org/fenfire/fenpdf/BUGS     Fri Aug 15 01:13:51 2003
@@ -1,9 +1,42 @@
 User-visible bugs in FenPDF 1.0
 ===============================
 
+FATAL:
+
+- unlink buoy doesn't work for transclusions!
+    [ architecture-wise we should separate the bindings
+      and actions as modularly as possible to help 
+      people build different things out of the parts.
+      Multiplexing actions by buoy type is one important thing.
+      ]
+
+- sometimes "not a canvas view"
+    [ architecture-wise: what the hell is AbstractMainNode2D
+      doing, checking members' derived types?
+      We need to think about what View2D needs to do.
+      getChildView2D is **NOT** a good solution.
+      ]
+
+- imported PDFs not added to treetime
+
+
+IMPORTANT:
+
+- buoys not shown when fast-panning! Culled to wrong cs / size
+  calculated wrong because not rendered??
+
+- transclusions move by dragging WITHOUT ctrl!!!
+
+ANNOYANCE:
+
 - Structlink connecting not done in the right way by spec
 
 - selection not removed at first other click
 
 - no click&drag of selected area to transclude
+
+- can't start fullscreen
+
+FIXED, BUT SYMPTOM OF DEEPER ARCHITECTURAL PROBLEM:
+
 
Index: fenfire/org/fenfire/fenpdf/fenpdfcontext.py
diff -u fenfire/org/fenfire/fenpdf/fenpdfcontext.py:1.4 
fenfire/org/fenfire/fenpdf/fenpdfcontext.py:1.5
--- fenfire/org/fenfire/fenpdf/fenpdfcontext.py:1.4     Thu Aug 14 08:13:03 2003
+++ fenfire/org/fenfire/fenpdf/fenpdfcontext.py Fri Aug 15 01:13:51 2003
@@ -172,7 +172,7 @@
         def run(self):
             link = self.states.buoymanager.buoyHit.link
             #(otherNode, linkId, otherAnchor, into)
-            if dbg: 
p('linkid',link[1],'otheranchor',link[2],'othernode',link[0])
+            p('Detaching 
linkid',link[1],'otheranchor',link[2],'othernode',link[0])
             pp = self.states.ppActions
             a,b = link[1].first, link[1].second
             pp.detachNotes(a, 1, b)
Index: fenfire/org/fenfire/view/View2D.java
diff -u fenfire/org/fenfire/view/View2D.java:1.8 
fenfire/org/fenfire/view/View2D.java:1.9
--- fenfire/org/fenfire/view/View2D.java:1.8    Wed Aug 13 12:56:28 2003
+++ fenfire/org/fenfire/view/View2D.java        Fri Aug 15 01:13:51 2003
@@ -124,4 +124,5 @@
      */
     public abstract Object getSelectedObject(Object plane, float x, float y, 
float w, float h);
 
+
 }
Index: fenfire/org/fenfire/view/buoy/AbstractMainNode2D.java
diff -u fenfire/org/fenfire/view/buoy/AbstractMainNode2D.java:1.43 
fenfire/org/fenfire/view/buoy/AbstractMainNode2D.java:1.44
--- fenfire/org/fenfire/view/buoy/AbstractMainNode2D.java:1.43  Thu Aug 14 
03:45:39 2003
+++ fenfire/org/fenfire/view/buoy/AbstractMainNode2D.java       Fri Aug 15 
01:13:51 2003
@@ -296,9 +296,12 @@
                .getNode(oldVobScene, (int)x, (int)y, 
                         plane, box2screen, box2screen,
                         box2paper, null);
-           if (obj != null) if (dbg) p("Object is: "+ obj.toString());
+           if (dbg) p("Object is: "+ (obj != null ? obj.toString() : obj));
            return obj;
-       } else p("not a canvas view?");
+       } else {
+           p("not a canvas view?");
+           new Throwable().printStackTrace();
+       }
        return null;
     }
 }




reply via email to

[Prev in Thread] Current Thread [Next in Thread]