fenfire-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [ff-cvs] libvob/vob/putil demo.py


From: Tuomas Lukka
Subject: Re: [ff-cvs] libvob/vob/putil demo.py
Date: Tue, 26 Aug 2003 11:31:01 +0300
User-agent: Mutt/1.5.4i

On Mon, Aug 25, 2003 at 04:48:13PM -0400, Matti Katila wrote:
> CVSROOT:      /cvsroot/libvob
> Module name:  libvob
> Branch:       
> Changes by:   Matti Katila <address@hidden>   03/08/25 16:48:13
> 
> Modified files:
>       vob/putil      : demo.py 
> 
> Log message:
>       must allow to save the data before quiting


> 
> Patches:
> Index: libvob/vob/putil/demo.py
> diff -u libvob/vob/putil/demo.py:1.19 libvob/vob/putil/demo.py:1.20
> --- libvob/vob/putil/demo.py:1.19     Mon Aug 25 03:02:33 2003
> +++ libvob/vob/putil/demo.py  Mon Aug 25 16:48:12 2003
> @@ -211,12 +211,13 @@
>           elif not globalkey(s):
>               currentScene.key(s)
>       else:
> +         if s == "Ctrl-R":
> +             loadScenes()
> +            if currentScene:
> +                currentScene.key(s)
>           if s == "Ctrl-Q":
>               System.exit(43)
> -         elif s == "Ctrl-R":
> -             loadScenes()
> -         else:
> -             currentScene.key(s)
> +
>       vob.AbstractUpdateManager.chg()

If you make a rearrangement like this, it would be useful to put in 
a comment to explain *why* it's coded like that. Otherwise, the change
is "flapping in the wind" and may be changed again by someone with
a different agenda.

        Tuomas




reply via email to

[Prev in Thread] Current Thread [Next in Thread]