fenfire-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Fenfire-dev] Re: [ff-cvs] fenfire/org/fenfire fenpdf/appearance/views.p


From: Tuomas Lukka
Subject: [Fenfire-dev] Re: [ff-cvs] fenfire/org/fenfire fenpdf/appearance/views.py ...
Date: Tue, 26 Aug 2003 21:39:45 +0300
User-agent: Mutt/1.5.4i

On Tue, Aug 26, 2003 at 07:34:42AM -0400, Matti Katila wrote:
> CVSROOT:      /cvsroot/fenfire
> Module name:  fenfire
> Branch:       
> Changes by:   Matti Katila <address@hidden>   03/08/26 07:34:41
> 
> Modified files:
>       org/fenfire/fenpdf/appearance: views.py 
>       org/fenfire/view: PageNodeView.java 
> Added files:
>       org/fenfire/view: VobWrapperFunction.java 
> 
> Log message:
>       vob wrapper function

The implementation looks much better now, good (and fast) work!

However, a small problem:

The javadoc in VobWrapperFunction is rather insufficient; 

1) there's no class javadoc, which means it's impossible to get an idea
of what the class does just from the class listing of Javadoc

2) 
    /** Wraps nodefunction, which function returns Placeable object, with
      * a vob.
      */

  This is incomprehensible. Wraps in what sense?

You just need to use more words to describe these things. Look at the example
code I posted that Tuukka committed a few days ago.

        Tuomas




reply via email to

[Prev in Thread] Current Thread [Next in Thread]