[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Fenfire-dev] (Alph) PEG imagescrollblock--humppake
From: |
Tuomas Lukka |
Subject: |
Re: [Fenfire-dev] (Alph) PEG imagescrollblock--humppake |
Date: |
Thu, 4 Sep 2003 11:30:37 +0300 |
User-agent: |
Mutt/1.5.4i |
On Wed, Sep 03, 2003 at 01:45:13PM +0300, Asko Soukka wrote:
> ==========================================================================
> PEG imagescrollblock--humppake: interface ImageScrollBlock
> ==========================================================================
>
> :Authors: Asko Soukka
> :Date-Created: 2003-09-03
> :Last-Modified: $Date: 2003/07/28 13:53:51 $
> :Revision: $Revision: 1.4 $
> :Status: Current
> :Status: Incomplete
???
> :Scope: Minor
> :Type: Interface
>
> This PEG prososes a new Alph scroll block type: ImageScrollBlock.
It's good to say the reason really briefly here: why is it needed now.
This gives context to the PEG.
> Issues
> ======
>
> What would ImageScrollBlock be?
>
> RESOLVED: ImageScrollBlock would be the interface for
> Alph scroll blocks containing only a single image.
Is this really an *issue*? Issues are something you're not
certain about - this sounds like a fake question ;)
Are you trying to avoid writing a real intro? ;)
> Aren't current interfaces enough?
>
> RESOLVED: The currently existing scroll block interfaces are
> PageScrollBlock and TextScrollBlock, both extending the basic
> ScrollBlock interface. TextScrollBlock is meant for text and
> PageScrollBlock for PDF and PS documents.
>
> Scroll blocks containing single images should be handled
> separately from both the text scroll blocks and PDF/PS document
> scroll blocks. Therefore, they need their own scroll block
> interface.
>
> What spesific methods should the new interface provide?
>
> RESOLVED: None for now. The interface is currently needed only
> to separate ImageScrollBlocks from other ScrollBlocks. New
> ImageScrollBlock spesific methods could be pegged later, if
> found necessary.
>
> Changes
> =======
>
> The creation of interface ``org.nongnu.alph.ImageScrollBlock``.
You should mention "with no methods" here, as having something only in the
issues
is bad form.
> Changing SimpleImageScroll to implement the new interface. No changes
> into SimpleImageScroll's code is needed.
Also, might be better to use the active form: "create the new interface ...,
Change Simple..."
Fix these and I'll accept.
Tuomas