Re: [Fenfire-dev] Clean commits

[Tuomas Lukka]

On Mon, Sep 08, 2003 at 10:58:15AM +0300, Matti Katila wrote:
> On Mon, 8 Sep 2003, Tuomas Lukka wrote:
> > Re: mudyc's latest commit
> > 
> > I noticed you removed the failing "testEmpty" at the same
> > time as moving the files. This is not a good practice
> > as CVS doesn't notify others of this.
> > 
> > Why was the test removed, are you sure it's not worth fixing?
> 
> I think the test writer has rigths to remove the test if he thinks it is 
> not needed and if the test has been committed accidentally with no 
> comments etc. ;) 

Yes, but even then, *only* with notification through the CVS commit.
A separate CVS commit, of *only* the removal of that test and with 
a clear message "Remove test XYZ because it tests X which is not really needed".

Communicating your actions and intentions to the community is vital.

        Tuomas