[Fenfire-dev] Re: [ff-cvs] fenfire/org/fenfire/fenpdf/events mousemenu.py

[Tuomas Lukka]

On Thu, Sep 11, 2003 at 10:50:20AM -0400, Matti Katila wrote:
> CVSROOT:      /cvsroot/fenfire
> Module name:  fenfire
> Branch:       
> Changes by:   Matti Katila <address@hidden>   03/09/11 10:50:20
> 
> Modified files:
>       org/fenfire/fenpdf/events: mousemenu.py 
> 
> Log message:
>       clean the eventHandler away
> 
> CVSWeb URLs:
> http://savannah.gnu.org/cgi-bin/viewcvs/fenfire/fenfire/org/fenfire/fenpdf/events/mousemenu.py.diff?tr1=1.9&tr2=1.10&r1=text&r2=text
> 
> Patches:
> Index: fenfire/org/fenfire/fenpdf/events/mousemenu.py
> diff -u fenfire/org/fenfire/fenpdf/events/mousemenu.py:1.9 
> fenfire/org/fenfire/fenpdf/events/mousemenu.py:1.10
> --- fenfire/org/fenfire/fenpdf/events/mousemenu.py:1.9        Tue Aug 26 
> 05:12:28 2003
> +++ fenfire/org/fenfire/fenpdf/events/mousemenu.py    Thu Sep 11 10:50:20 2003
> @@ -14,10 +14,9 @@
>  dbg = 0
>  
>  class MouseMenu:
> -    def __init__(self, fenPDF, states, eventHandler):
> +    def __init__(self, fenPDF, states):
>          self.fenPDF = fenPDF
>          self.states = states
> -        self.eventHandler = eventHandler
>          self.style = vob.GraphicsAPI.getInstance().getTextStyle('sans', 0, 
> 12)
>          self.makeMainList()
>          self.hideList()
> @@ -52,7 +51,7 @@
>          vs.put(self.selectListVob, cs)
>  
>      def showList(self, x, y, who):
> -        self.eventHandler.eventGrabber = self.mouse
> +        self.fenPDF.events.eventHandler.eventGrabber = self.mouse
>          self.dragged = 0
>          self.notExecuted = 1
>       p("showList")

You're adding a member from afar? It *would* be nicer to call a method
of eventHandler to say "Grab is here". 

A better abstraction.

        Tuomas