fenfire-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Fenfire-dev] Mudyc merge request


From: Tuomas Lukka
Subject: [Fenfire-dev] Mudyc merge request
Date: Mon, 6 Oct 2003 17:31:20 +0300
User-agent: Mutt/1.5.4i

I'll accept this merge but I want to see the following changes REAL soon
(merging because your changes were not separated to suitable branches and
some are needed in the mainline):

        +++ mod/include/vob/vobs/Trivial.hxx
        @@ -300,6 +300,39 @@

         VOB_DEFINED(TransTest);

         +
         +/** A Vob to draw a selection with 3 'selection modes'.
         + * 2nd coordinate system is used to select the current mode.
         + * The mode is represented by a vob. These 3 possibile 'selection 
mode'
         + * vobs are set in parameters.
         + * <p>
         + * Modes(2nd cs square size width):
         + *    <=1 normal,
         + *    <= 2 pre selection and
         + *    other is post selection.
         + */

This is not good: the selectVob is a far more general tool, you are now talking
about a single application. The javadoc should not mention anything like
pre selection, post selection except as an *example* of how it can be used.

Also, why is t0 the one to be passed to the vobs and t1 the condition?

I'd like to see

t0 = condition

t1, ... = *VARIABLE* number of parameter coordinate systems, all passed to 
children.

-----

What kind of a name is "FocusWithBuoysManager"? It doesn't tell me anything.

-----

AbstractSelectVob should also be in lava for the time being, along with 
SelectItemVob &c.

        Tuomas




reply via email to

[Prev in Thread] Current Thread [Next in Thread]