[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Fenfire-dev] Mudyc's merge request
From: |
Tuomas Lukka |
Subject: |
[Fenfire-dev] Mudyc's merge request |
Date: |
Thu, 30 Oct 2003 09:54:23 +0200 |
User-agent: |
Mutt/1.5.4i |
Boomerang:
1) ParallelView2D has no javadoc. I'd like to have a discussion
of what it is and what's the architecture, could you write
a quick (15-min) PEG about the idea? It shouldn't be too much
more work than the javadoc alone; if the javadoc is good,
the PEG would just be the main javadoc.
2) SelectionPainter would be nice to have a javadoc also; but since
it wasn't introduced in this patch I'm not going to demand it
but I'd like to see it documented
3) In the changes to fenpdfcontext, there is the "height" variable - what is it
the height of? "XXX Ugly" is not a good comment, it should
also describe what the variable is, for the benefits of us
others.
4) Using getVersion() to enable extensions is NOT good - since
the extensions have not been formally approved.
I'd prefer separate flags for each extension::
if fenPDF.useExtension("TextCloud"): ...
That way, it's easy to later define new versions just by
making them enable the extensions.
Tuomas