Re: [Fenfire-dev] Libvob: Modifications in base classes.

[Matti Katila]

On Sun, 7 Mar 2004, Benja Fallenstein wrote:
> About this PEG, I agree it should be implemented. We should at some 
> point go through it together to fix grammar &c, though (because it's 
> important documentation). Not before the article dl, tho.
> 
> > I list the differenties here so you can comment on:
> > Well, I would like to change this to 
> > 
> >     VobScene generate(VobScene emptyVS);
> 
> What does the emptyVS mean?

VobScene which is empty. Scene has beem created but not filled. Usually 
the view code fills the scene, currently it also creates the scene.

> > --- orig/org/nongnu/libvob/VobScene.java
> > +++ mod/org/nongnu/libvob/VobScene.java
> > @@ -137,6 +137,8 @@
> >      public final VobCoorder coords;
> >      public final VobMatcher matcher;
> >  
> > +    public WindowAnimation anim = null;
> > +
> >      public final GraphicsAPI gfxapi;
> >      public final GraphicsAPI.RenderingSurface window;
> 
> I don't like this, why not
> 
>      public final WindowAnimation anim;
> 
> and set it in the constructor?

Because the PEG doesn't say to add modifications into VobScene ;)


   -Matti