[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Findutils-patches] patch for #20662 memory leak
From: |
Eric Blake |
Subject: |
Re: [Findutils-patches] patch for #20662 memory leak |
Date: |
Sun, 05 Aug 2007 06:47:49 -0600 |
User-agent: |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.6) Gecko/20070728 Thunderbird/2.0.0.6 Mnenhy/0.7.5.666 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
According to James Youngman on 8/5/2007 4:34 AM:
> On 8/5/07, Eric Blake <address@hidden> wrote:
>> OK to commit? Should I port the entire patch back to the branch,
>> including the -nowarn and testsuite changes; or just the memory leak fix?
>
> Great patch; thanks! Yes, please commit. I also think it is
> worthwhile backporting the whole thing to 4.2.x.
>
> Just one tiny nit...
>
>> + if (strchr(arg, '/') && options.warnings)
>
> Reversing this test will avoid a tiny performance hit for long arguments.
Committed with that nit fixed.
- --
Don't work too hard, make some time for fun as well!
Eric Blake address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFGtcb184KuGfSFAYARAjknAJwMkrY2Q5dmAhchV61QCAAs4VJi2gCfW16Y
C3+Un1B6Eib/H51lqGcvIhQ=
=ZCct
-----END PGP SIGNATURE-----