[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Findutils-patches] [PATCH] Check gnulib out with git rather than CV
From: |
Eric Blake |
Subject: |
Re: [Findutils-patches] [PATCH] Check gnulib out with git rather than CVS. |
Date: |
Tue, 27 Nov 2007 18:31:47 -0700 |
User-agent: |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.9) Gecko/20071031 Thunderbird/2.0.0.9 Mnenhy/0.7.5.666 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
According to James Youngman on 11/27/2007 4:29 AM:
> diff --git a/doc/find-maint.texi b/doc/find-maint.texi
> index 5f176f1..c025452 100644
> --- a/doc/find-maint.texi
> +++ b/doc/find-maint.texi
> @@ -484,7 +484,9 @@ GNU libc system with a bug in the regex implementation.
> @section How and Why we Import the Gnulib Code
> Gnulib does not have a release process which results in a source
> tarball you can download. Instead, the code is simply made available
> -by CVS.
> +by GIT. The code is also available via @code{git-cvspserver}, but
> +since that lacks working support for @code{cvs update -D}, we don't
> +use it.
git might fix this in the future. How about s/lacks working support/\$ as
of this writing/, to add some future-proofing?
> @item Check out a copy of the Gnulib source
> -An easy way to do this is to simply use @code{cp -ar} on the
> address@hidden directory. Have the Gnulib code checked out
> -somewhere @emph{outside} your working CVS tree for findutils.
> +An easy way to do this is to use @code{git clone} to clone a local
> +gnulib repository you already generated with @code{import-gnulib.sh}.
> +Have the Gnulib code checked out somewhere @emph{outside} your working
> +CVS tree for findutils.
I think the import-gnulib.sh should probably use a shallow clone to cut
down on network bandwidth usage; but that means that cloning the
gnulib-git directory into an external git directory won't work. So maybe
this paragraph should be revisited.
> +Update the findutils file @file{import-gnulib.config} to specify git
> +commit which is after the point at which the bug fix was committed to
> +Gnulib. You can do this with @code{git show HEAD}.
I'm wondering if git rev-parse HEAD is better here.
> +that we were relying on to fix the bug. Make sure you checkjed
s/checkjed/checked/
- --
Don't work too hard, make some time for fun as well!
Eric Blake address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFHTMUD84KuGfSFAYARAkuOAJwOKFSPEh50pNNikeGB8ghUPKiRSACgrvou
Oxpoz/PW4zYC5gMfodFIxuE=
=H2Un
-----END PGP SIGNATURE-----