[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Findutils-patches] [PATCH 12/19] sc_prohibit_strcmp gives false positiv
From: |
James Youngman |
Subject: |
[Findutils-patches] [PATCH 12/19] sc_prohibit_strcmp gives false positives when neither argument is a constant, so skip that check |
Date: |
Fri, 2 Apr 2010 23:47:12 +0100 |
---
cfg.mk | 9 ++++++---
1 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/cfg.mk b/cfg.mk
index 9b6f8ad..b43b3e5 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -24,8 +24,7 @@ skip_dunno = sc_immutable_NEWS sc_makefile_at_at_check \
# Understand, but fix later.
skip_defer = sc_program_name \
- sc_prohibit_magic_number_exit sc_prohibit_stat_st_blocks \
- sc_prohibit_strcmp
+ sc_prohibit_magic_number_exit sc_prohibit_stat_st_blocks
# False positives I don't have a workaround for yet.
# sc_space_tab: several .xo test output files contain this sequence
@@ -47,6 +46,10 @@ skip_blocked_patch = sc_useless_cpp_parens
skip_blocked_notours = \
sc_texinfo_acronym
+# sc_prohibit_strcmp is broken because it gives false positives for cases
+# where neither argument is a string literal.
+skip_broken_checks = sc_prohibit_strcmp
+
local-checks-to-skip = \
$(skip_too_picky) $(skip_dunno) $(false_positives) $(skip_defer) \
- $(mix_positives) $(skip_blocked_patch) $(skip_blocked_notours)
+ $(mix_positives) $(skip_blocked_patch) $(skip_blocked_notours)
$(skip_broken_checks)
--
1.7.0
- [Findutils-patches] [PATCH 04/19] Fix some compilation unused-result and missing-declaration warnings., (continued)
- [Findutils-patches] [PATCH 04/19] Fix some compilation unused-result and missing-declaration warnings., James Youngman, 2010/04/02
- [Findutils-patches] [PATCH 08/19] Move safe_atoi out into a separate module., James Youngman, 2010/04/02
- [Findutils-patches] [PATCH 09/19] Remove some obsolete source files from POTFILES.in, James Youngman, 2010/04/02
- [Findutils-patches] [PATCH 10/19] Remove files which exist but have no translated messages., James Youngman, 2010/04/02
- [Findutils-patches] [PATCH 11/19] Avoid sscanf. Avoid false positives for sc_prohibit_atoi_atof., James Youngman, 2010/04/02
- [Findutils-patches] [PATCH 07/19] configure.ac: Quote the first argument to AC_DEFINE., James Youngman, 2010/04/02
- [Findutils-patches] [PATCH 13/19] Enable syntax checker sc_the_the, detecting doubled 'the'., James Youngman, 2010/04/02
- [Findutils-patches] [PATCH 12/19] sc_prohibit_strcmp gives false positives when neither argument is a constant, so skip that check,
James Youngman <=
- [Findutils-patches] [PATCH 14/19] Avoid sc_prohibit_stat_st_blocks check, since it is broken., James Youngman, 2010/04/02
- [Findutils-patches] [PATCH 16/19] Use set_program_name() to remember the programs' names., James Youngman, 2010/04/02
- [Findutils-patches] [PATCH 15/19] Avoid using magic numbers as exit statuses., James Youngman, 2010/04/02
- [Findutils-patches] [PATCH 18/19] cfg.mk: simplify variables, James Youngman, 2010/04/02
- [Findutils-patches] [PATCH 17/19] Don't include quote.h/quotearg.h where it is not used., James Youngman, 2010/04/02
- [Findutils-patches] [PATCH 19/19] Check for accidental modifications to the wrong section of the NEWS file., James Youngman, 2010/04/02