[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Findutils-patches] [PATCH 17/19] Don't include quote.h/quotearg.h where
From: |
James Youngman |
Subject: |
[Findutils-patches] [PATCH 17/19] Don't include quote.h/quotearg.h where it is not used. |
Date: |
Fri, 2 Apr 2010 23:47:17 +0100 |
* find/find.c: Don't include "quote.h", it's not used.
* find/ftsfind.c: Likewise.
* find/parser.c: Likewise.
* locate/locate.c: Likewise.
* locate/word_io.c: Likewise.
* cfg.mk (skip_dunno): Enable check sc_prohibit_quote_without_use.
* find/find.c: Don't include "quotearg.h", it's not used.
* lib/fdleak.c: Likewise.
Signed-off-by: James Youngman <address@hidden>
---
ChangeLog | 10 ++++++++++
cfg.mk | 3 +--
find/find.c | 2 --
find/ftsfind.c | 1 -
find/parser.c | 1 -
lib/fdleak.c | 1 -
locate/locate.c | 1 -
locate/word_io.c | 1 -
8 files changed, 11 insertions(+), 9 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 1ceb300..472cabe 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,15 @@
2010-04-02 James Youngman <address@hidden>
+ Don't include quote.h/quotearg.h where it is not used.
+ * find/find.c: Don't include "quote.h", it's not used.
+ * find/ftsfind.c: Likewise.
+ * find/parser.c: Likewise.
+ * locate/locate.c: Likewise.
+ * locate/word_io.c: Likewise.
+ * cfg.mk (skip_dunno): Enable check sc_prohibit_quote_without_use.
+ * find/find.c: Don't include "quotearg.h", it's not used.
+ * lib/fdleak.c: Likewise.
+
Use set_program_name() to remember the programs' names.
* cfg.mk *skip(defer): Enable sc_program_name. Remove the
now-unused variable skip_defer.
diff --git a/cfg.mk b/cfg.mk
index 8b336a3..24d7f83 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -19,8 +19,7 @@ skip_too_picky = sc_error_message_period
sc_error_message_uppercase \
sc_file_system
# Errors I have not investigated; diagnose and fix later.
-skip_dunno = sc_immutable_NEWS sc_makefile_at_at_check \
- sc_prohibit_quote_without_use sc_prohibit_quotearg_without_use
+skip_dunno = sc_immutable_NEWS sc_makefile_at_at_check
# False positives I don't have a workaround for yet.
# sc_space_tab: several .xo test output files contain this sequence
diff --git a/find/find.c b/find/find.c
index d3a239e..336e120 100644
--- a/find/find.c
+++ b/find/find.c
@@ -46,8 +46,6 @@
#include "savedirinfo.h"
#include "buildcmd.h"
#include "dirname.h"
-#include "quote.h"
-#include "quotearg.h"
#include "xgetcwd.h"
#include "error.h"
#include "fdleak.h"
diff --git a/find/ftsfind.c b/find/ftsfind.c
index 3b56026..c3681f6 100644
--- a/find/ftsfind.c
+++ b/find/ftsfind.c
@@ -47,7 +47,6 @@
#include "progname.h"
#include "closeout.h"
#include "quotearg.h"
-#include "quote.h"
#include "fts_.h"
#include "save-cwd.h"
#include "xgetcwd.h"
diff --git a/find/parser.c b/find/parser.c
index 2fa302c..2ea3126 100644
--- a/find/parser.c
+++ b/find/parser.c
@@ -31,7 +31,6 @@
#include "modechange.h"
#include "xstrtol.h"
#include "xalloc.h"
-#include "quote.h"
#include "quotearg.h"
#include "buildcmd.h"
#include "nextelem.h"
diff --git a/lib/fdleak.c b/lib/fdleak.c
index 19e252f..2c362cf 100644
--- a/lib/fdleak.c
+++ b/lib/fdleak.c
@@ -32,7 +32,6 @@
#include "dirent-safer.h"
#include "extendbuf.h"
#include "cloexec.h"
-#include "quotearg.h"
#include "safe-atoi.h"
#include "fdleak.h"
#include "error.h"
diff --git a/locate/locate.c b/locate/locate.c
index 84377ac..0cab522 100644
--- a/locate/locate.c
+++ b/locate/locate.c
@@ -126,7 +126,6 @@
#include "closeout.h"
#include "nextelem.h"
#include "regex.h"
-#include "quote.h"
#include "quotearg.h"
#include "printquoted.h"
#include "regextype.h"
diff --git a/locate/word_io.c b/locate/word_io.c
index e783dfd..575f26f 100644
--- a/locate/word_io.c
+++ b/locate/word_io.c
@@ -25,7 +25,6 @@
#include <stdlib.h>
#include "error.h"
-#include "quote.h"
#include "quotearg.h"
#include "locatedb.h"
--
1.7.0
- [Findutils-patches] [PATCH 11/19] Avoid sscanf. Avoid false positives for sc_prohibit_atoi_atof., (continued)
- [Findutils-patches] [PATCH 11/19] Avoid sscanf. Avoid false positives for sc_prohibit_atoi_atof., James Youngman, 2010/04/02
- [Findutils-patches] [PATCH 07/19] configure.ac: Quote the first argument to AC_DEFINE., James Youngman, 2010/04/02
- [Findutils-patches] [PATCH 13/19] Enable syntax checker sc_the_the, detecting doubled 'the'., James Youngman, 2010/04/02
- [Findutils-patches] [PATCH 12/19] sc_prohibit_strcmp gives false positives when neither argument is a constant, so skip that check, James Youngman, 2010/04/02
- [Findutils-patches] [PATCH 14/19] Avoid sc_prohibit_stat_st_blocks check, since it is broken., James Youngman, 2010/04/02
- [Findutils-patches] [PATCH 16/19] Use set_program_name() to remember the programs' names., James Youngman, 2010/04/02
- [Findutils-patches] [PATCH 15/19] Avoid using magic numbers as exit statuses., James Youngman, 2010/04/02
- [Findutils-patches] [PATCH 18/19] cfg.mk: simplify variables, James Youngman, 2010/04/02
- [Findutils-patches] [PATCH 17/19] Don't include quote.h/quotearg.h where it is not used.,
James Youngman <=
- [Findutils-patches] [PATCH 19/19] Check for accidental modifications to the wrong section of the NEWS file., James Youngman, 2010/04/02