findutils-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Findutils-patches] [PATCH 2/2] Fix further compiler warnings.


From: Eric Blake
Subject: Re: [Findutils-patches] [PATCH 2/2] Fix further compiler warnings.
Date: Tue, 14 Jun 2011 16:52:07 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.10

On 06/14/2011 04:46 PM, James Youngman wrote:
> * find/ftsfind.c (show_outstanding_execdirs): Now that
> execp->state.cmd_argc is a size_t, we can't print it with %d.  So
> print it with PRIuMAX (and include <inttypes.h> to define that).

Or suck in the fprintf-posix module, and use %zu instead of PRIuMAX, to
save a cast.  But that's pretty heavy-weight, so your approach is fine.

> @@ -31,6 +42,7 @@
>       (prec_name): Likewise!  Also remove spurious parentheses around
>       return value.
>       (prec_name): Remove spurious parentheses around return value.
> +
>       * lib/buildcmd.h (buildcmd_state): change types of several fields

Was this hunk intentional?

-- 
Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]