[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Findutils-patches] Patches to -type x,y,z
From: |
Dale R. Worley |
Subject: |
Re: [Findutils-patches] Patches to -type x,y,z |
Date: |
Wed, 06 Apr 2016 12:14:20 -0400 |
Bernhard Voelker <address@hidden> writes:
> I thought a bit about the implementation and thought it'd be better
> to avoid artificially creating the OR-ed predicates, and rather store
> the wanted file types in an array and check for that in pred.c.
> I think this should be faster, too.
I may be overlooking something, but:
+ float type_rate = 0.0;
Is this variable used anywhere?
+ our_pred->est_success_rate += rate;
Is est_success_rate set to zero before the loop that contains this?
Looking at tree.c (albeit from an older version), get_new_pred()
initializes est_success_rate to 1.0, not 0.0.
Dale