[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Findutils-patches] [PATCH] Do not leave fd_limit as an unused varia
Re: [Findutils-patches] [PATCH] Do not leave fd_limit as an unused variable on the stack if getrlimit is not supported.
Wed, 8 Aug 2018 13:34:35 +0200
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1
On 08/08/2018 01:11 PM, Bernhard Voelker wrote:
On 08/08/2018 09:39 AM, Aron Barath wrote:
* lib/fdleak.c (get_max_fd): add guard around the fd_limit variable
Thanks for the patch.
I'd favor to give that variable a better scope instead of adding another
#if/#endif block. I'll push the attached in your name unless you have
Thanks & have a nice day,
It is fine, the point is to avoid compiler error if getrlimit is not
supported (because the struct rlimit is not exists).
Thank you very much,