[Freeipmi-devel] ipmi-sendto

[Albert Chu]

Hey AB,

In ipmi_sendto:

----------------
  /*
    Note from Table 12-8, RMCP Packet for IPMI via Ethernet footnote
    Some LAN adapter chips may have a problem where packets of overall
    lengths 56, 84, 112, 128, or 156 are not handled correctly. The
    PAD byte is added as necessary to avoid these overall
    lengths. Remote console software must use the PAD byte when
    formatting packets to any 10/100 Ethernet device that accepts RMCP
    packets.
  */
  len = sizeof (rmcp_hdr_t) + ipmi_pkt_len + IPMI_LAN_PACKET_PAD_SIZE;
----------------

I'm pretty darn sure that this means:

len = sizeof(rmcp_hdr_t) + ipmi_pkt_len;
if (len == 56 or 84 or 112 or 128 or 156)
    len+=IPMI_LAN_PACKET_PAD_SIZE;

I'm going to go ahead and change it.  

Al

--
Albert Chu
address@hidden
Lawrence Livermore National Laboratories