Re: [Freeipmi-devel] [bugs #8414] Poor handling of values that can only be set on certain platforms

[Anand Babu]

,----[ "Joseph Ruscio" <address@hidden> ]
| Summary: Poor handling of values that can only be set on certain
| platforms
| 
| Original Submission: The file containg the current configuration of
| the BMC output from executing contains a comment for each option,
| listing all acceptable values.
| 
| Many of the configuration options do not accept all of the values
| listed in the comments. I assume this is a platform specific
| situation. Currently attmpeting to set these values result in errors
| of the following types:
| 
| error: ipmi_kcs_set_user_access: 204: Invalid data field in Request.
| 
| error: ipmi_lan_set_ip_addr_source: 204: Invalid data field in
| Request.
| 
| These are cryptic and should be replaced with something similar to
| this:
| 
| "Unable to set requested <KEY> to <VALUE> either due to specific
| platform restrictions or value being invalid."
`----


   error: ipmi_kcs_set_user_access: 204: Invalid data field in
   Request.

Current error handler is generic and can exactly translate  BMC's
error response code to some meaningful English text like 
"Invalid data field in Request". Actual possibilities are huge.

I like the current error handler. Lets see what everyone else thinks.


-- 
 _.|_ 
(_||_)
Free as in Freedom <www.gnu.org>