Re: [Freeipmi-devel] IPMI_TRACE

[Anand Babu]

Yes save_errno is required.

Purpose of IPMI_TRACE is to enable fprintf display while
debugging. (only for developers)

In fact I'm planning to enable even "ERR macro syslog" only in
IPMI_TRACE. ERR macro is supposed to just return the error safely to
the parent call. Top most call should gracefully handle the it. 

For example, failed sensors, non-root execution ... they all are
handled properly at higher level. But in IPMI_TRACE mode, you will
notice a trace of all the lower level calls that has failed, spitting
error messages to the console.

,----
| Perhaps I'm missing something, but why was the #ifndef (IPMI_TRACE)
| ERR() macro added into ipmi-error.h??  The save_errno code I added into
| the original ERR() macro was to protect against errno being over-written
| by fprintf errors.  In particular,
`----

-- 
 _.|_ 
(_||_)
Free as in Freedom <www.gnu.org>