[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Freeipmi-devel] Patch for hex k_g keys in ipmipower

From: Al Chu
Subject: Re: [Freeipmi-devel] Patch for hex k_g keys in ipmipower
Date: Thu, 26 Apr 2007 11:59:19 -0700

Hey Levi,

> > I think we want:
> > 
> > if (!(isgraph(k_g[i]) || k_g[i] == ' ')
> >     || (foundnull && k_g[i] != '\0')
> If the null check is true, there's a continue, which skips the second
> check entirely.  So whenever the second check is run, we know k_g[i] !=
> '\0', so we only need to check if there was a null found before this
> character.

Ahhh, I see now.  Cool.

> Hopefully I'll have all these changes incorporated sometime later today.
> Thanks for the review.

Cool.  Thanks


Albert Chu
Computer Scientist
High Performance Systems Division
Lawrence Livermore National Laboratory

reply via email to

[Prev in Thread] Current Thread [Next in Thread]