[Freeipmi-devel] Re: Fujitsu's iRMC S2 - support for "get SEL entry long text" within ipmi-oem

[Albert Chu]

Hey Dan,

Attached is my reworked patch for ipmi-oem.  Can you give it a shot and
LMK if it works?

I cleaned up some chunks for code consistency to other code in ipmi-oem
and added a manpage entry.  I ended up removing the "first" and "last"
because I guess I don't see users wanting to/commonly using it.  Do you
feel different?  I can see "last" more often then "first" though
(similar to how I have a 'tail' option in ipmi-sel, but not a 'head').

I did (atleast try) to implement the code to loop if there was more text
to retrieve.  Hopefully I implemented it right.

Also, I slightly tweaked the output to more similarly match ipmi-sel
output, adding in semi-colons and stuff.  I admit, I'm not entirely sure
of the output.  You may have specifically chosen your output b/c it
matches some other Fujitsu tool??  We can tweak as necessary.

PLMK what you think.

Al

P.S.  You'll probably get ChangeLog and NEWS conflicts in this patch,
but you can ignore those of course.  The code patches appear to apply
cleanly to FreeIPMI 0.8.8.

On Tue, 2010-08-17 at 12:13 -0700, Dan Lukes wrote:
> On 08/17/10 20:04, Albert Chu:
> > I'll tweak a few formatting things to be consistent to other parts of 
> > FreeIPMI, and I think I'll do "first" and "last" instead of "0"
> > or "-1" for the first/last SEL entry.
> 
> You are welcome.
> 
> > But I'm a tad confused on this in your printf at the end:
> >
> > data_len == text_len ? "" : " ... (text incomplete)");
> >
> > Is there some subtlety of the get-sel-long-text OEM command that isn't
> > clear to me
> 
> Total size of message related to a SEL may be larger than specified 
> MaxResponseDataSize (MaxResponseDataSize can't exceed 100 on my system 
> or the call will fail).
> 
> The "data length" field in response contain length of complete message 
> (not the part returned just now). If you received incomplete message 
> (e.g. actual length is less than claimed data length) then you can call 
> function again, with non-zero Offset field in request, to obtain the 
> rest of message.
> 
> I didn't implemented repeated call so the text "incomplete" instead of it.
> 
>                                       Dan
> 
> 
> 
-- 
Albert Chu
address@hidden
Computer Scientist
High Performance Systems Division
Lawrence Livermore National Laboratory

fujitsu_get_sel_entry_long_text.patch
Description: Text Data