[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [Freeipmi-devel] Re: Patch for Fujitsu OEM Sensor Types and SEL deco
RE: [Freeipmi-devel] Re: Patch for Fujitsu OEM Sensor Types and SEL decoding
Fri, 10 Sep 2010 11:04:53 -0700
On Fri, 2010-09-10 at 02:58 -0700, Liebig, Holger wrote:
> > Hey Holger,
> > I finally got to this patch. I've created a branch for this:
> > svn co svn://svn.sv.gnu.org/freeipmi/branches/fujitsu-0-8-0
> > I had to re-work a few things for consistency to the other code
> > (subtleties I'm sure you just missed, no biggie).
> Hey Al,
> Thanks for taking a closer look at the provided patch. As you guessed
> correctly, I will need more time to check the details ;)
BTW, if it helps, revision 7319 is application of your patch, revision
7319-7321 are my cleanup, and from that point on are my changes.
> With the proposed --output-oem-event-string option a customer has the
> option to get (exactly) the same output from freeipmi as he gets from
> the other interfaces of the BMC.
That's a good point I hadn't considered, even further reason to
implement it. So I went ahead and did it. The
--output-oem-event-strings option is in ipmi-sel in that branch.
Naturally, it's untested since I don't have a motherboard with such
support, so I may have screwed something up :P
High Performance Systems Division
Lawrence Livermore National Laboratory