Re: [Freeipmi-devel] FreeIPMI daemons & systemd

[Albert Chu]

Hi Jan,

Thanks, patch commited.  It'll be in the next release.

Al

On Fri, 2012-01-06 at 07:46 -0800, Jan Safranek wrote:
> Hi,
> 
> I'm writing and testing unit files for systemd, the new init for Fedora
> 16 and later and I stumbled upon race condition when bmc-watchdog and
> ipmidetectd does double fork.
> 
> Systemd expects that the binary (e.g. bmc-watchdog) exits *after* the
> final daemon process is forked, i.e. both forks are finished. FreeIPMI
> code calls exit() in the parent right after the first fork, which might
> be before the second fork(). Systemd then sometimes marks the service as
> failed.
> 
> Attached you can find simple patch, fixing both daemons using a pipe for
> communication. I tested only ipmidetectd daemon, I'm still looking for
> some HW to test bmc-watchdog (we usually don't run Fedora on such HW).
> 
> Jan
-- 
Albert Chu
address@hidden
Computer Scientist
High Performance Systems Division
Lawrence Livermore National Laboratory